Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

fix 404 url #1163

Merged
merged 2 commits into from
Feb 26, 2020
Merged

fix 404 url #1163

merged 2 commits into from
Feb 26, 2020

Conversation

liubo0127
Copy link
Contributor

@liubo0127 liubo0127 commented Feb 25, 2020 •
edited
Loading

@july2993 PTAL

@liubo0127
Copy link
Contributor Author

#1162

july2993
july2993 reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
but I think we should refer to the docs in pingcap.com instead of markdown at GitHub

@liubo0127
Copy link
Contributor Author

Keep using GitHub link first, I forgot the purpose of using GitHub link. If necessary, change it later.

@liubo0127 liubo0127 merged commit 2248349 into pingcap:master Feb 26, 2020
@liubo0127 liubo0127 deleted the liubo/update-ntp-link branch February 26, 2020 03:50
liubo0127 added a commit to liubo0127/tidb-ansible that referenced this pull request Feb 26, 2020
@liubo0127
fix 404 url (pingcap#1163)
2133680 
* fix 404 url

* update ntp check url
@liubo0127 liubo0127 mentioned this pull request Feb 26, 2020
Merged
liubo0127 added a commit that referenced this pull request Feb 26, 2020
@liubo0127
fix 404 url (#1163) (#1167)
e5aa088 
* fix 404 url

* update ntp check url
liubo0127 added a commit to liubo0127/tidb-ansible that referenced this pull request Feb 26, 2020
@liubo0127
fix 404 url (pingcap#1163)
fc80a12 
* fix 404 url

* update ntp check url
@liubo0127 liubo0127 mentioned this pull request Feb 26, 2020
Merged
liubo0127 added a commit that referenced this pull request Feb 26, 2020
@liubo0127
fix 404 url (#1163) (#1168)
98dc9ff 
* fix 404 url

* update ntp check url
liubo0127 added a commit to liubo0127/tidb-ansible that referenced this pull request Feb 26, 2020
@liubo0127
fix 404 url (pingcap#1163)
ea3487e 
* fix 404 url

* update ntp check url
@liubo0127 liubo0127 mentioned this pull request Feb 26, 2020
Merged
liubo0127 added a commit that referenced this pull request Feb 26, 2020
@liubo0127
fix 404 url (#1163) (#1169)
d4b1d47 
* fix 404 url

* update ntp check url
liubo0127 added a commit to liubo0127/tidb-ansible that referenced this pull request Feb 26, 2020
@liubo0127
fix 404 url (pingcap#1163)
9567403 
* fix 404 url

* update ntp check url
@liubo0127 liubo0127 mentioned this pull request Feb 26, 2020
Merged
liubo0127 added a commit that referenced this pull request Feb 26, 2020
@liubo0127
fix 404 url (#1163) (#1170)
d3b8567 
* fix 404 url

* update ntp check url
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@july2993 july2993 july2993 approved these changes

Assignees
No one assigned
Labels
bug master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liubo0127 @july2993