Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: let hot region balance not affect by balance-region-scheduler-limit #1522

Merged
merged 4 commits into from
May 8, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 28, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

In some situation, the balance region has preempted the limiter, and the hot region balance has no chance to schedule.

What is changed and how it works?

change the AllowSchedule condition.

Check List

Tests

  • Unit test

`balance-region-scheduler-limit`

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the type/enhancement The issue or PR belongs to an enhancement. label Apr 28, 2019
@codecov-io
Copy link

codecov-io commented Apr 28, 2019

Codecov Report

Merging #1522 into master will decrease coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
- Coverage    67.7%   67.66%   -0.05%     
==========================================
  Files         158      158              
  Lines       15648    15649       +1     
==========================================
- Hits        10595    10589       -6     
- Misses       4094     4096       +2     
- Partials      959      964       +5
Impacted Files Coverage Δ
server/schedulers/hot_region.go 75.45% <83.33%> (-1.39%) ⬇️
pkg/etcdutil/etcdutil.go 86.04% <0%> (-9.31%) ⬇️
server/util.go 70.86% <0%> (-7.29%) ⬇️
server/leader.go 80.49% <0%> (-2.49%) ⬇️
server/tso.go 72.72% <0%> (-2.28%) ⬇️
server/grpc_service.go 58.31% <0%> (-0.89%) ⬇️
server/cluster.go 74.26% <0%> (-0.54%) ⬇️
client/client.go 68.25% <0%> (+0.21%) ⬆️
server/namespace_cluster.go 85.71% <0%> (+1.29%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a02baa...6224e92. Read the comment docs.

@disksing disksing merged commit 4573d20 into tikv:master May 8, 2019
@nolouch nolouch deleted the hot-limit branch May 8, 2019 12:32
nolouch added a commit that referenced this pull request May 23, 2019
* tiny clean up code (#1526)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config:  enable use region storage by default (#1524)

* config: default enable use region storage

* schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522)

Signed-off-by: nolouch <nolouch@gmail.com>

* log: do not add stack to error log (#1532)

* *: replace gofail with pingcap/failpoint (#1534)

* *: replace gofail with pingcap/failpoint

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster_test.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* check enable failpoint result

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster.go

Co-Authored-By: Lonng <chris@lonng.org>

* server: set timeout for MoveLeader (#1533)

* server: set timeout for MoveLeader

Signed-off-by: disksing <i@disksing.com>

* client, server: add ScanRegions gRPC protocol support (#1535)

* client, server: support ScanRegions gRPC protocol

Signed-off-by: disksing <i@disksing.com>

* schedule: actively push operator  (#1536)

* schedule: actively push operator

Signed-off-by: nolouch <nolouch@gmail.com>

* *: update some dead links (#1543)

* update links

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* Add windows build script (#1540)

Signed-off-by: Ana Hobden <operator@hoverbear.org>

* fix operator timeout metrics (#1541)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* *:Rollback config in store when kv.persist failed (#1476)

* tests: independent region sync test (#1545)

* tests: independent syncer region test

Signed-off-by: nolouch <nolouch@gmail.com>

* schedule: operator limit for stores (#1474)

* add store limit for scheduling

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* statistic: add the statistic of flow (#1548)

* store_statistic: add the statistic of flow

Signed-off-by: nolouch <nolouch@gmail.com>
nolouch added a commit to nolouch/pd that referenced this pull request May 29, 2019
…uler-limit (tikv#1522)

Signed-off-by: nolouch <nolouch@gmail.com>
nolouch added a commit to nolouch/pd that referenced this pull request May 29, 2019
…uler-limit (tikv#1522)

Signed-off-by: nolouch <nolouch@gmail.com>
rleungx pushed a commit that referenced this pull request May 29, 2019
*: make hot region scheduler configurable (#1412)

Signed-off-by: nolouch <nolouch@gmail.com>

* use high priority for the hot region related operators (#1492)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522)

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants