Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: add DroppingDefinitions for PartitionInfo #970

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

ldeng-ustc
Copy link
Contributor

@ldeng-ustc ldeng-ustc commented Aug 11, 2020

What is changed and how it works?

Proposal: TiDB #18982

add ·DroppingDefinitionsfield toPartitionInfo` , so partitionsInfo can temporary in it to support reorganization of global index in dropping partitions.

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #970 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #970   +/-   ##
=======================================
  Coverage   78.43%   78.43%           
=======================================
  Files          40       40           
  Lines       15043    15043           
=======================================
  Hits        11799    11799           
  Misses       2544     2544           
  Partials      700      700           

@tiancaiamao
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Aug 27, 2020
@tiancaiamao tiancaiamao requested a review from AilinKid August 27, 2020 08:08
Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Aug 28, 2020
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Aug 28, 2020
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 LGT3. This PR looks very good to our bot. and removed status/LGT2 LGT2 labels Aug 28, 2020
@AilinKid AilinKid merged commit a883f6f into pingcap:master Aug 28, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution status/LGT3 LGT3. This PR looks very good to our bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants