Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add require secure transport error (#779) #780

Merged
merged 2 commits into from
Mar 18, 2020
Merged

add require secure transport error (#779) #780

merged 2 commits into from
Mar 18, 2020

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Mar 18, 2020 •
edited
Loading

cherry-pick #779 to 3.1

no conflict

This change is Reviewable

@lysu lysu mentioned this pull request Mar 18, 2020
Merged
@codecov
Copy link

codecov bot commented Mar 18, 2020 •
edited
Loading

Codecov Report

Merging #780 into release-3.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-3.1     #780   +/-   ##
============================================
  Coverage        64.65%   64.65%           
============================================
  Files               31       31           
  Lines            11211    11211           
============================================
  Hits              7248     7248           
  Misses            3552     3552           
  Partials           411      411
Impacted Files Coverage Δ
model/ddl.go 76.99% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a313c64...b05824b. Read the comment docs.

@lysu lysu requested a review from imtbkcat March 18, 2020 04:01
@tiancaiamao
Copy link
Collaborator

LGTM

jackysp
jackysp approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit f0b8f6c into pingcap:release-3.1 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@imtbkcat imtbkcat Awaiting requested review from imtbkcat

Assignees
No one assigned
Labels
status/LGT1 LGT1 type/cherry-pick-for-release-3.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lysu @tiancaiamao @jackysp