Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 support nowait grammar #616

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

cfzjywxk
Copy link
Contributor

@cfzjywxk cfzjywxk commented Nov 6, 2019

What problem does this PR solve?

cherry-pick #582 to release 3.0

the tidb related cherry-pick is link

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

Related changes

  • Need to update the documentation
  • Need to be included in the release note

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #616 into release-3.0 will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0     #616      +/-   ##
===============================================
- Coverage        50.99%   50.97%   -0.02%     
===============================================
  Files               31       31              
  Lines             6844     6846       +2     
===============================================
  Hits              3490     3490              
- Misses            3005     3007       +2     
  Partials           349      349
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/util.go 27.27% <0%> (ø) ⬆️
ast/dml.go 40.41% <0%> (-0.07%) ⬇️
ast/functions.go 70.56% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555b970...87fb8f0. Read the comment docs.

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit c499e11 into pingcap:release-3.0 Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants