Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: fix the select field text [DNM] #596

Closed
wants to merge 1 commit into from

Conversation

tiancaiamao
Copy link
Collaborator

Try to fix the select field text bug introduced in #587

mysql> SELECT @@`autocommit` LIMIT 1;
+------------------------+
| @@`autocommit` LIMIT 1 |
+------------------------+
| 1                      |
+------------------------+
1 row in set (0.00 sec)

which should be

mysql> SELECT @@`autocommit`;
+----------------+
| @@`autocommit` |
+----------------+
| 1              |
+----------------+
1 row in set (0.00 sec)

I'm not sure it's a good fix, pr/587 seems to introduce some other problems.
For example, is this a correct gramma in MySQL?

select 1 where true group by 1 having 1>0

@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #596 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   79.75%   79.76%   +<.01%     
==========================================
  Files          32       32              
  Lines       12489    12493       +4     
==========================================
+ Hits         9961     9965       +4     
  Misses       1939     1939              
  Partials      589      589
Impacted Files Coverage Δ
parser.go 92.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8839bb5...3bfb24d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant