Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support CREATE VIEW ... UnionStmt (#572) #574

Merged
merged 1 commit into from
Oct 11, 2019
Merged

support CREATE VIEW ... UnionStmt (#572) #574

merged 1 commit into from
Oct 11, 2019

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #572

@codecov
Copy link

codecov bot commented Oct 11, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@2a177b2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-3.0     #574   +/-   ##
==============================================
  Coverage               ?   50.99%           
==============================================
  Files                  ?       31           
  Lines                  ?     6844           
  Branches               ?        0           
==============================================
  Hits                   ?     3490           
  Misses                 ?     3005           
  Partials               ?      349
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø)
ast/ddl.go 44.47% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a177b2...c78488f. Read the comment docs.

wshwsh12
wshwsh12 reviewed Oct 11, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kennytm
kennytm reviewed Oct 11, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT2 LGT2 label Oct 11, 2019
@kennytm kennytm merged commit 1f407b3 into pingcap:release-3.0 Oct 11, 2019
@XuHuaiyu XuHuaiyu deleted the release-3.0 branch October 12, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/cherry-pick-for-release-3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuHuaiyu @kennytm @wshwsh12