Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IGNORE_INDEX hint #550

Merged
merged 4 commits into from
Sep 12, 2019
Merged

Conversation

foreyes
Copy link
Contributor

@foreyes foreyes commented Sep 6, 2019

What problem does this PR solve?

Add IGNORE_INDEX hint for optimizer.

What is changed and how it works?

Add new key word into parser and handle it.

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Related changes

@foreyes foreyes self-assigned this Sep 6, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foreyes foreyes added the status/LGT1 LGT1 label Sep 7, 2019
lzmhhh123
lzmhhh123 previously approved these changes Sep 7, 2019
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lzmhhh123 lzmhhh123 added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Sep 7, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #550 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   71.76%   71.76%           
=======================================
  Files          32       32           
  Lines        7813     7813           
=======================================
  Hits         5607     5607           
  Misses       1676     1676           
  Partials      530      530
Impacted Files Coverage Δ
misc.go 96.49% <ø> (ø) ⬆️
parser.go 70.58% <ø> (ø) ⬆️
ast/misc.go 74.46% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab4974...cbd4f25. Read the comment docs.

@lzmhhh123 lzmhhh123 merged commit 978b827 into pingcap:master Sep 12, 2019
@foreyes foreyes deleted the dev/add_ignore_index_hint branch September 12, 2019 03:27
foreyes added a commit to foreyes/parser that referenced this pull request Sep 16, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants