mysql: add write conflict error for latch and change the error code of ErrTxnTooLarge #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
jackysp
requested review from
tiancaiamao,
lysu,
coocood and
crazycs520
and removed request for
tiancaiamao
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=======================================
Coverage 53.38% 53.38%
=======================================
Files 31 31
Lines 6519 6519
=======================================
Hits 3480 3480
Misses 2700 2700
Partials 339 339Continue to review full report at Codecov.
|
coocood
reviewed
May 21, 2019
| @@ -941,6 +943,4 @@ const ( | |||
| ErrRegionUnavailable = 9005 | |||
| ErrGCTooEarly = 9006 | |||
| ErrWriteConflict = 9007 | |||
|
|
|||
| ErrTxnTooLarge = 9500 | |||
There was a problem hiding this comment.
It is not a related change. But ErrTxnTooLarge is a TiDB error, it should not in the TiKV/PD section.
There was a problem hiding this comment.
It is better to keep the TiDB errors starts from 8000 and TiKV/PD's starts from 9000.
There was a problem hiding this comment.
I've updated the title and the description.
jackysp
changed the title
|
LGTM |
alivxxx
pushed a commit
to alivxxx/parser
that referenced
this pull request
Oct 22, 2019
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
alivxxx
added a commit
to alivxxx/parser
that referenced
this pull request
Oct 22, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
Add write conflict error for latch and change the error code of ErrTxnTooLarge.