-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issues 280: Support ON UPDATE ddl statements #331
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 53.38% 53.38%
=======================================
Files 31 31
Lines 6519 6519
=======================================
Hits 3480 3480
Misses 2700 2700
Partials 339 339
Continue to review full report at Codecov.
|
I have signed "You have signed the CLA for pingcap/parser" on May 20th 2019 13:03 EST, yet it still shows as not signed in checklist above |
This comment has been minimized.
This comment has been minimized.
5ead50a
to
02ed801
Compare
LGTM |
@winkyao I can resolve conflict on parser.go (generated file), but most likely it will become a conflict again as soon as any change to grammar is made (another PR merged). I have parser.go as a separate commit, specifically for purpose to simplify rebasing. Please let me know how you'd like to proceed |
02ed801
to
84139ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gleonid Could you resolve the conflicts? |
These changes are approved, thanks for your contribution |
84139ee
to
1558cff
Compare
1558cff
to
43deec6
Compare
The CI is failed with error:
@crazycs520 will help to fix ci. |
@winkyao The integration test error will be fixed by pingcap/tidb#11184. |
43deec6
to
bf6a623
Compare
conflict is resolved but now approval is required again |
* issues 280: Support ON UPDATE ddl statements * issue 280: add generated file
* issues 280: Support ON UPDATE ddl statements * issue 280: add generated file
* issues 280: Support ON UPDATE ddl statements * issue 280: add generated file
* issues 280: Support ON UPDATE ddl statements * issue 280: add generated file (cherry picked from commit 191583a)
* issues 280: Support ON UPDATE ddl statements * issue 280: add generated file
What problem does this PR solve?
"CREATE TABLE child ( id INT, parent_id INT, INDEX par_ind (parent_id), FOREIGN KEY (parent_id) REFERENCES parent(id) ON UPDATE CASCADE)" fails to parse even though grammar looks like it should b able to
What is changed and how it works?
ReferDef: "REFERENCES" TableName '(' IndexColNameList ')' OnDeleteOpt OnUpdateOpt
is replaced withCheck List
Tests
added
Code changes
no
no
no
Side effects
performance test was not performed
existing tests pass