Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ast: Change the implementation of Accept for DefaultExpr" #1013

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Revert "ast: Change the implementation of Accept for DefaultExpr" #1013

merged 1 commit into from
Sep 8, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 8, 2020

Reverts #1007 since the corresponding TiDB pingcap/tidb#19869 is not ready now.

@rebelice
Copy link
Contributor

rebelice commented Sep 8, 2020

LGTM

@ti-srebot
Copy link
Contributor

@rebelice,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: ddl(slack).

@qw4990 qw4990 requested a review from AilinKid September 8, 2020 09:33
AilinKid
AilinKid approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Sep 8, 2020
@qw4990
Copy link
Contributor Author

qw4990 commented Sep 8, 2020

Thanks @AilinKid

@imtbkcat
Copy link

imtbkcat commented Sep 8, 2020

/merge

@ti-srebot
Copy link
Contributor

@imtbkcat Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: ddl(slack).

@imtbkcat imtbkcat merged commit 4d637af into master Sep 8, 2020
@kennytm kennytm deleted the revert-1007-master branch September 8, 2020 10:30
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@qw4990
Revert "ast: Change the implementation of Accept for DefaultExpr (pin…
bae2260 
…gcap#1007)" (pingcap#1013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
status/LGT1 LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @rebelice @ti-srebot @imtbkcat @AilinKid