Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TiDB behavior: reorganize partition #605

Closed
tangenta opened this issue Oct 31, 2019 · 0 comments · Fixed by #924
Closed

Fix TiDB behavior: reorganize partition #605

tangenta opened this issue Oct 31, 2019 · 0 comments · Fixed by #924
Labels
good first issue Good for newcomers

Comments

@tangenta
Copy link
Contributor

tangenta commented Oct 31, 2019 •
edited
Loading

Index issue: #598

SQL example

ALTER TABLE x REORGANIZE PARTITION p0 (PARTITION …);

Current implementation

AlterTableReorganizePartition is ignored by TiDB.

Expected implementation

Report an error for REORGANIZE PARTITION because it can change the meaning of a partition.
@tangenta tangenta mentioned this issue Oct 31, 2019
Closed
11 tasks
@tangenta tangenta added the good first issue Good for newcomers label Dec 11, 2019
@tangenta tangenta changed the title Fix TiDB behavior: reorganize/exchange partition Fix TiDB behavior: reorganize partition Jul 2, 2020
wangggong pushed a commit to wangggong/parser that referenced this issue Jul 11, 2020
fix: remove warning for "REORGANIZE PARTITION" (pingcap#605)
ba9191b 
Note that in commit fdfeac in pingcap/tidb the errror was already handled.
Need to do nothing.

Signed-off-by: Wang Ruichao <wangruichao2014@xiaochuankeji.cn>
@wangggong wangggong mentioned this issue Jul 11, 2020
Merged
kennytm pushed a commit that referenced this issue Jul 18, 2020
fix: remove warning for "REORGANIZE PARTITION" (#605) (#924)
3dd0dd2 
Note that in commit fdfeac in pingcap/tidb the errror was already handled.
Need to do nothing.

Signed-off-by: Wang Ruichao <wangruichao2014@xiaochuankeji.cn>
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this issue Apr 27, 2021
fix: remove warning for "REORGANIZE PARTITION" (pingcap#605) (pingcap…
547d7c7 
…#924)

Note that in commit fdfeac in pingcap/tidb the errror was already handled.
Need to do nothing.

Signed-off-by: Wang Ruichao <wangruichao2014@xiaochuankeji.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove warning for "REORGANIZE PARTITION" (#605) wangggong/parser
1 participant
@tangenta