Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_raw_kv field to backup request and meta #513

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Add is_raw_kv field to backup request and meta #513

merged 3 commits into from
Dec 11, 2019

Conversation

MyonKeminta
Copy link
Contributor

This PR adds is_raw_kv field to BackupRequest and BackupMeta.
This is used to support raw kv mode of backup ( pingcap/br#86 )

@MyonKeminta
Copy link
Contributor Author

@overvenus @3pointer PTAL

overvenus
overvenus previously approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3pointer
3pointer previously approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，please resolve conflicts

@MyonKeminta MyonKeminta dismissed stale reviews from 3pointer and overvenus via 880215d December 11, 2019 03:18
@MyonKeminta MyonKeminta mentioned this pull request Dec 11, 2019
Closed
@MyonKeminta
Copy link
Contributor Author

@overvenus @3pointer PTAL again

overvenus
overvenus approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus overvenus merged commit 5dbce7e into pingcap:master Dec 11, 2019
@MyonKeminta MyonKeminta deleted the m/backup-raw-kv branch December 11, 2019 03:32
MyonKeminta added a commit to MyonKeminta/kvproto that referenced this pull request Dec 11, 2019
@MyonKeminta
Add is_raw_kv field to backup request and meta (pingcap#513)
7b88422 
* Add is_raw_kv field to backup request and meta

* build
@MyonKeminta MyonKeminta mentioned this pull request Dec 11, 2019
Merged
3pointer pushed a commit that referenced this pull request Dec 11, 2019
@MyonKeminta @3pointer
3.1: Add is_raw_kv field to backup request and meta (#513) (#520)
a3b5e04 
* upgrade protoc version (#515)

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

* Add is_raw_kv field to backup request and meta (#513)

* Add is_raw_kv field to backup request and meta

* build
daimashusheng pushed a commit to daimashusheng/kvproto that referenced this pull request Sep 2, 2021
@MyonKeminta @overvenus
Add is_raw_kv field to backup request and meta (pingcap#513)
9dbb9fd 
* Add is_raw_kv field to backup request and meta

* build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MyonKeminta @overvenus @3pointer