pdpb: add ScanRegions #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
| message ScanRegionsResponse { | ||
| ResponseHeader header = 1; | ||
| repeated metapb.Region regions = 2; | ||
| repeated metapb.Peer leaders = 3; |
There was a problem hiding this comment.
How about region has no leader?
There was a problem hiding this comment.
It will add empty value to make regions and leaders are matched.
Signed-off-by: disksing <i@disksing.com>
disksing
requested review from
zhangjinpeng87 and
MyonKeminta
and removed request for
zhangjinpeng87
MyonKeminta
reviewed
May 14, 2019
Signed-off-by: disksing <i@disksing.com>
|
@disksing Please cherry-pick to release-3.0 branch, thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com