-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConfChange::AddLearnerNode command. #212
Changes from 5 commits
3bf14f7
b778f00
3d93169
fb07200
f0ffeca
8db5953
0790693
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,6 +51,7 @@ message Region { | |
optional bytes end_key = 3; | ||
optional RegionEpoch region_epoch = 4; | ||
repeated Peer peers = 5; | ||
repeated Peer learners = 6; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should remove this too. |
||
} | ||
|
||
message Peer { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -233,6 +233,7 @@ message RegionHeartbeatRequest { | |
enum ConfChangeType { | ||
AddNode = 0; | ||
RemoveNode = 1; | ||
AddLearnerNode = 2; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why change this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought pd should also support There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. But not in this pr. |
||
} | ||
|
||
message ChangePeer { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
learners
[0]?[0] https://github.com/coreos/etcd/pull/8751/files#diff-ed53c23ad570cdd6dce39cbd1b751cacR80