This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
dumpling/gcs: fix http client credential problem (#395) #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
1 task
lichunzhu
reviewed
Nov 23, 2021
lichunzhu
approved these changes
Nov 23, 2021
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: de5b84f
|
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: ce39d20
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #395
What problem does this PR solve?
cherry-pick of pingcap/tidb#29414
What is changed and how it works?
Dumpling will fail to export data to GCS because of a lack of privileges when we set our own HTTP client without specifying transport tls. This PR deletes it.
Check List
Tests
Test dump data with dumpling before/after this commit. Before this commit GCS will return a gcs error "google api: Error 401: anonymous caller does not have storage.object.create access to the Google Cloud Storage object.". After this commit dumpling can successfully dump data to GCS.
Related changes
Release note