Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

sql: fix where condition without brackets problem (#372) #375

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #372

What problem does this PR solve?

close #371

What is changed and how it works?

If both conf.Where and where has a value, we use brackets to wrap these two conditions.

Check List

Tests

  • Unit test
  • Integration test
    Dumpling before this commit can't pass new integration tests.

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release note

  • fix the problem that dumpling may dump extra data if --where is specified

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer approved (LGTM1) label Oct 15, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 7963fe8

@ti-chi-bot ti-chi-bot merged commit 341844e into pingcap:release-5.1 Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants