address comment

pingcap · Jul 15, 2021 · 972a640 · 972a640
1 parent f1e35da
commit 972a640
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/v4/export/config.go b/v4/export/config.go
@@ -169,13 +169,6 @@ func DefaultConfig() *Config {
 	}
 }
 
-// Clone clones a dumpling config.
-func (conf *Config) Clone() *Config {
-	clone := &Config{}
-	*clone = *conf
-	return clone
-}
-
 // String returns dumpling's config in json format
 func (conf *Config) String() string {
 	cfg, err := json.Marshal(conf)

diff --git a/v4/export/writer_util_test.go b/v4/export/writer_util_test.go
@@ -297,15 +297,22 @@ func (s *testWriteSuite) TestWrite(c *C) {
 	c.Assert(err, IsNil)
 }
 
+// cloneConfigForTest clones a dumpling config.
+func cloneConfigForTest(conf *Config) *Config {
+	clone := &Config{}
+	*clone = *conf
+	return clone
+}
+
 func configForWriteSQL(config *Config, fileSize, statementSize uint64) *Config {
-	cfg := config.Clone()
+	cfg := cloneConfigForTest(config)
 	cfg.FileSize = fileSize
 	cfg.StatementSize = statementSize
 	return cfg
 }
 
 func configForWriteCSV(config *Config, noHeader bool, opt *csvOption) *Config {
-	cfg := config.Clone()
+	cfg := cloneConfigForTest(config)
 	cfg.NoHeader = noHeader
 	cfg.CsvNullValue = opt.nullValue
 	cfg.CsvDelimiter = string(opt.delimiter)