-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add specific operations in TiDB-Binlog Cluster #868
tools: add specific operations in TiDB-Binlog Cluster #868
Conversation
|
||
Step 1: Deploy `pump_servers` and `node_exporters` | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click "View file" in the upper right corner, you can see the format is wrong.
tools/tidb-binlog-cluster.md
Outdated
|
||
For how to use Ansible to deploy the TiDB cluster, see [Deploy TiDB Using Ansible](../op-guide/ansible-deployment.md). When Binlog is enabled, Pump is deployed and started by default. | ||
**Method #1**: Add Pump on the existing TiDB cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add back the one-sentence description above the "Method #1" line.
tools/tidb-binlog-cluster.md
Outdated
For how to use Ansible to deploy the TiDB cluster, see [Deploy TiDB Using Ansible](../op-guide/ansible-deployment.md). When Binlog is enabled, Pump is deployed and started by default. | ||
**Method #1**: Add Pump on the existing TiDB cluster | ||
|
||
Step 1: Deploy `pump_servers` and `node_exporters` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step 1: Deploy `pump_servers` and `node_exporters` | |
1. Deploy `pump_servers` and `node_exporters` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directly using the number is better here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@WangXiangUSTC PTAL. Thanks! |
Via: pingcap/docs-cn#1081 PTAL @lilin90 @KASSADAR