Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-variables: update from generated source #7289

Merged
merged 3 commits into from
Jan 18, 2022
Merged

system-variables: update from generated source #7289

merged 3 commits into from
Jan 18, 2022

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Dec 17, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

This updates the system-variables documentation, automatically generated from the source code.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

rand_seed from pingcap/tidb#29936
backoff_lock_fast is from tikv/client-go#388
tidb_store_limit from pingcap/tidb#30522

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@morgo morgo requested a review from dveeden December 17, 2021 14:36
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 17, 2021
@shichun-0415 shichun-0415 added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. translation/doing This PR's assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. labels Dec 18, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Dec 18, 2021
@shichun-0415 shichun-0415 self-assigned this Dec 18, 2021
TomShawn
TomShawn reviewed Dec 20, 2021
View reviewed changes
system-variables.md
@@ -463,7 +479,7 @@ MPP is a distributed computing framework provided by the TiFlash engine, which a
### tidb_backoff_lock_fast

- Scope: SESSION | GLOBAL
- Default value: `100`
- Default value: `10`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seiya-annie PTAL this default value change. From which version this value has been changed?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still 100 in v5.3.0, maybe a new change for master

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the checklist at the time there was no option, but I selected master.

This affects TiDB 5.4 and above.

@TomShawn TomShawn added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed sig/docs Indicates that the Issue or PR belongs to the docs SIG. labels Dec 20, 2021
@TomShawn TomShawn added the v5.4 This PR/issue applies to TiDB v5.4. label Dec 30, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7d4d1e7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2022
@ti-chi-bot ti-chi-bot merged commit be6b87c into pingcap:master Jan 18, 2022
@shichun-0415 shichun-0415 mentioned this pull request Feb 7, 2022
Merged
15 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@dveeden dveeden dveeden approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@seiya-annie seiya-annie seiya-annie approved these changes

Assignees

@shichun-0415 shichun-0415

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. type/enhancement The issue or PR belongs to an enhancement. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@morgo @ti-chi-bot @TomShawn @dveeden @Defined2014 @seiya-annie @shichun-0415