Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links #6837

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Fix broken links #6837

merged 5 commits into from
Nov 18, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 17, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Fix broken links

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Related:

Link checker output file: link-checker/out.md
README.md
	ERROR	https://github.com/pingcap/docs/tree/release-5.3
		Not Found (HTTP error 404)
tidb-binlog/binlog-consumer-client.md
	ERROR	https://github.com/pingcap/tidb-tools/blob/master/tidb-binlog/proto/proto/binlog.proto
		Not Found (HTTP error 404)
tidb-binlog/tidb-binlog-overview.md
	ERROR	https://github.com/pingcap/tidb-binlog/blob/master/proto/binlog.proto
		Not Found (HTTP error 404)
adopters.md
	ERROR	http://company.funyours.co.jp/
		X509: certificate signed by unknown authority
	ERROR	https://nn.yjyz.com/
		Dial tcp4 47.113.27.42:443: connect: connection refused
connectors-and-apis.md
	ERROR	http://www.clifford.at/spl/spldoc/sql_mysql.html
		Lookup www.clifford.at on 168.63.129.16:53: read udp 172.17.0.2:45696->168.63.129.16:53: i/o timeout

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2021
@dveeden dveeden mentioned this pull request Nov 17, 2021
Merged
13 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2021
TomShawn
TomShawn reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix!

The external link checker is only for reference and does not block merge. We do not need to fix every link reported by the checker. It often reports false broken links merely due to poor connectivity. In fact, these links are through if you try it. In addition, some links are merely displayed in this GitHub repo, not on docs.pingcap.com or anywhere else.

README.md Outdated Show resolved Hide resolved
adopters.md Show resolved Hide resolved
adopters.md Outdated Show resolved Hide resolved
connectors-and-apis.md Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2021
@TomShawn TomShawn self-assigned this Nov 18, 2021
@TomShawn TomShawn added type/bugfix This PR fixes a bug. translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 18, 2021
TomShawn
TomShawn approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 18, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7ef8fa4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2021
@ti-chi-bot ti-chi-bot merged commit b818cb5 into pingcap:master Nov 18, 2021
dveeden added a commit to dveeden/docs that referenced this pull request Dec 3, 2021
@dveeden
link-check: exclude funyours.co.jp
b783de0 
http://company.funyours.co.jp/ redirects to https://www.funyours.co.jp
and that host doesn't present a correct/complete certificate chain. In
addition to that it looks like the certificate and hostname don't match.

https://www.ssllabs.com/ssltest/analyze.html?d=www.funyours.co.jp

Previous discussion: pingcap#6837 (comment)

```
$ curl -v -L http://company.funyours.co.jp/
*   Trying 210.152.118.91:80...
* Connected to company.funyours.co.jp (210.152.118.91) port 80 (#0)
> GET / HTTP/1.1
> Host: company.funyours.co.jp
> User-Agent: curl/7.79.1
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 301 Moved Permanently
< Server: nginx
< Date: Fri, 03 Dec 2021 06:37:29 GMT
< Content-Type: text/html
< Content-Length: 178
< Connection: keep-alive
< Location: https://www.funyours.co.jp
<
* Ignoring the response-body
* Connection #0 to host company.funyours.co.jp left intact
* Issue another request to this URL: 'https://www.funyours.co.jp/'
*   Trying 47.245.16.139:443...
* Connected to www.funyours.co.jp (47.245.16.139) port 443 (#1)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
*  CApath: none
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: unable to get local issuer certificate
* Closing connection 1
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
```
@dveeden dveeden mentioned this pull request Dec 3, 2021
Merged
13 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 3, 2021
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 3, 2021
@dveeden @ti-chi-bot
link-check: exclude funyours.co.jp
3953239 
http://company.funyours.co.jp/ redirects to https://www.funyours.co.jp
and that host doesn't present a correct/complete certificate chain. In
addition to that it looks like the certificate and hostname don't match.

https://www.ssllabs.com/ssltest/analyze.html?d=www.funyours.co.jp

Previous discussion: pingcap#6837 (comment)

```
$ curl -v -L http://company.funyours.co.jp/
*   Trying 210.152.118.91:80...
* Connected to company.funyours.co.jp (210.152.118.91) port 80 (#0)
> GET / HTTP/1.1
> Host: company.funyours.co.jp
> User-Agent: curl/7.79.1
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 301 Moved Permanently
< Server: nginx
< Date: Fri, 03 Dec 2021 06:37:29 GMT
< Content-Type: text/html
< Content-Length: 178
< Connection: keep-alive
< Location: https://www.funyours.co.jp
<
* Ignoring the response-body
* Connection #0 to host company.funyours.co.jp left intact
* Issue another request to this URL: 'https://www.funyours.co.jp/'
*   Trying 47.245.16.139:443...
* Connected to www.funyours.co.jp (47.245.16.139) port 443 (pingcap#1)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
*  CApath: none
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: unable to get local issuer certificate
* Closing connection 1
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
```
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 3, 2021
@dveeden @ti-chi-bot
link-check: exclude funyours.co.jp
a4e0fad 
http://company.funyours.co.jp/ redirects to https://www.funyours.co.jp
and that host doesn't present a correct/complete certificate chain. In
addition to that it looks like the certificate and hostname don't match.

https://www.ssllabs.com/ssltest/analyze.html?d=www.funyours.co.jp

Previous discussion: pingcap#6837 (comment)

```
$ curl -v -L http://company.funyours.co.jp/
*   Trying 210.152.118.91:80...
* Connected to company.funyours.co.jp (210.152.118.91) port 80 (#0)
> GET / HTTP/1.1
> Host: company.funyours.co.jp
> User-Agent: curl/7.79.1
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 301 Moved Permanently
< Server: nginx
< Date: Fri, 03 Dec 2021 06:37:29 GMT
< Content-Type: text/html
< Content-Length: 178
< Connection: keep-alive
< Location: https://www.funyours.co.jp
<
* Ignoring the response-body
* Connection #0 to host company.funyours.co.jp left intact
* Issue another request to this URL: 'https://www.funyours.co.jp/'
*   Trying 47.245.16.139:443...
* Connected to www.funyours.co.jp (47.245.16.139) port 443 (pingcap#1)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
*  CApath: none
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: unable to get local issuer certificate
* Closing connection 1
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
```
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 3, 2021
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 3, 2021
@dveeden @ti-chi-bot
link-check: exclude funyours.co.jp
823c522 
http://company.funyours.co.jp/ redirects to https://www.funyours.co.jp
and that host doesn't present a correct/complete certificate chain. In
addition to that it looks like the certificate and hostname don't match.

https://www.ssllabs.com/ssltest/analyze.html?d=www.funyours.co.jp

Previous discussion: pingcap#6837 (comment)

```
$ curl -v -L http://company.funyours.co.jp/
*   Trying 210.152.118.91:80...
* Connected to company.funyours.co.jp (210.152.118.91) port 80 (#0)
> GET / HTTP/1.1
> Host: company.funyours.co.jp
> User-Agent: curl/7.79.1
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 301 Moved Permanently
< Server: nginx
< Date: Fri, 03 Dec 2021 06:37:29 GMT
< Content-Type: text/html
< Content-Length: 178
< Connection: keep-alive
< Location: https://www.funyours.co.jp
<
* Ignoring the response-body
* Connection #0 to host company.funyours.co.jp left intact
* Issue another request to this URL: 'https://www.funyours.co.jp/'
*   Trying 47.245.16.139:443...
* Connected to www.funyours.co.jp (47.245.16.139) port 443 (pingcap#1)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
*  CApath: none
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: unable to get local issuer certificate
* Closing connection 1
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
```
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 3, 2021
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 3, 2021
@dveeden @ti-chi-bot
link-check: exclude funyours.co.jp
b9a48a3 
http://company.funyours.co.jp/ redirects to https://www.funyours.co.jp
and that host doesn't present a correct/complete certificate chain. In
addition to that it looks like the certificate and hostname don't match.

https://www.ssllabs.com/ssltest/analyze.html?d=www.funyours.co.jp

Previous discussion: pingcap#6837 (comment)

```
$ curl -v -L http://company.funyours.co.jp/
*   Trying 210.152.118.91:80...
* Connected to company.funyours.co.jp (210.152.118.91) port 80 (#0)
> GET / HTTP/1.1
> Host: company.funyours.co.jp
> User-Agent: curl/7.79.1
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 301 Moved Permanently
< Server: nginx
< Date: Fri, 03 Dec 2021 06:37:29 GMT
< Content-Type: text/html
< Content-Length: 178
< Connection: keep-alive
< Location: https://www.funyours.co.jp
<
* Ignoring the response-body
* Connection #0 to host company.funyours.co.jp left intact
* Issue another request to this URL: 'https://www.funyours.co.jp/'
*   Trying 47.245.16.139:443...
* Connected to www.funyours.co.jp (47.245.16.139) port 443 (pingcap#1)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
*  CApath: none
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: unable to get local issuer certificate
* Closing connection 1
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
```
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 3, 2021
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 3, 2021
@dveeden @ti-chi-bot
link-check: exclude funyours.co.jp
6216f2d 
http://company.funyours.co.jp/ redirects to https://www.funyours.co.jp
and that host doesn't present a correct/complete certificate chain. In
addition to that it looks like the certificate and hostname don't match.

https://www.ssllabs.com/ssltest/analyze.html?d=www.funyours.co.jp

Previous discussion: pingcap#6837 (comment)

```
$ curl -v -L http://company.funyours.co.jp/
*   Trying 210.152.118.91:80...
* Connected to company.funyours.co.jp (210.152.118.91) port 80 (#0)
> GET / HTTP/1.1
> Host: company.funyours.co.jp
> User-Agent: curl/7.79.1
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 301 Moved Permanently
< Server: nginx
< Date: Fri, 03 Dec 2021 06:37:29 GMT
< Content-Type: text/html
< Content-Length: 178
< Connection: keep-alive
< Location: https://www.funyours.co.jp
<
* Ignoring the response-body
* Connection #0 to host company.funyours.co.jp left intact
* Issue another request to this URL: 'https://www.funyours.co.jp/'
*   Trying 47.245.16.139:443...
* Connected to www.funyours.co.jp (47.245.16.139) port 443 (pingcap#1)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: /etc/pki/tls/certs/ca-bundle.crt
*  CApath: none
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: unable to get local issuer certificate
* Closing connection 1
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
```
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 3, 2021
Merged
13 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 19, 2022
@TomShawn TomShawn mentioned this pull request Apr 19, 2022
Merged
16 tasks
This was referenced Apr 20, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaitinChen CaitinChen CaitinChen left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dveeden @ti-chi-bot @TomShawn @CaitinChen