Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc:add config for hot region history and add command for pd ctl #6627

Merged
merged 13 commits into from
Jan 20, 2022
Merged

doc:add config for hot region history and add command for pd ctl #6627

merged 13 commits into from
Jan 20, 2022

Conversation

qidi1
Copy link
Contributor

@qidi1 qidi1 commented Oct 18, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

add config for hot region history and add command for pd ctl.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.3 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qidi1
add discription of history hot region
76c5034 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
add discription of history hot region
ceba420 
Signed-off-by: qidi1 <1083369179@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Oct 18, 2021
@ti-chi-bot
Copy link
Member

Welcome @qidi1!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2021
@qidi1 qidi1 mentioned this pull request Oct 18, 2021
Merged
15 tasks
This was referenced Oct 18, 2021
Merged
Merged
@TomShawn TomShawn added v5.3 This PR/issue applies to TiDB v5.3. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 19, 2021
@qidi1 qidi1 mentioned this pull request Oct 24, 2021
Merged
14 tasks
@TomShawn TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed v5.3 This PR/issue applies to TiDB v5.3. translation/doing This PR's assignee is translating this PR. labels Nov 3, 2021
@TomShawn TomShawn added v5.4 This PR/issue applies to TiDB v5.4. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Dec 21, 2021
@TomShawn TomShawn assigned qidi1 and unassigned qidi1 Dec 21, 2021
@IcePigZDB IcePigZDB mentioned this pull request Dec 30, 2021
Open
hfxsd
hfxsd reviewed Jan 6, 2022
View reviewed changes
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
qidi1 and others added 3 commits January 6, 2022 11:33
@qidi1 @hfxsd
Update pd-configuration-file.md
e33502a 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qidi1 @hfxsd
Update pd-configuration-file.md
d08dce2 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qidi1 @hfxsd
Update pd-configuration-file.md
8062663 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
hfxsd
hfxsd reviewed Jan 6, 2022
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
hfxsd and others added 6 commits January 6, 2022 11:57
@hfxsd
Apply suggestions from code review
10d7c6e
@qidi1
address commit
e367f11 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
pdctl: update hot history usage comment
a9991cc 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
pdctl: update hot history usage return example
78b84e9 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
pdctl: formate hot history usage return example
a4e4862 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
pdctl: update hot history slice use case
c8c2b98 
Signed-off-by: qidi1 <1083369179@qq.com>
hfxsd
hfxsd approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2022
@qidi1 qidi1 mentioned this pull request Jan 15, 2022
Closed
@nolouch
Copy link
Member

nolouch commented Jan 17, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
Copy link
Member

nolouch commented Jan 18, 2022

ptal @en-jin19

TomShawn
TomShawn approved these changes Jan 20, 2022
View reviewed changes
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 20, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8d926f7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@TomShawn
Copy link
Contributor

/verify

1 similar comment
@TomShawn
Copy link
Contributor

/verify

@ti-chi-bot ti-chi-bot merged commit 5e5dd4c into pingcap:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@hfxsd hfxsd hfxsd approved these changes

@TomShawn TomShawn TomShawn approved these changes

@en-jin19 en-jin19 Awaiting requested review from en-jin19

Assignees

@hfxsd hfxsd

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qidi1 @ti-chi-bot @CLAassistant @nolouch @TomShawn @hfxsd