Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: remove category meta #3227

Merged
merged 3 commits into from
Jul 14, 2020
Merged

dev: remove category meta #3227

merged 3 commits into from
Jul 14, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jul 10, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Remove category in metadata.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 10, 2020
@TomShawn TomShawn requested review from lilin90, yikeke and ran-huang and removed request for lilin90 and yikeke July 10, 2020 05:58
@lilin90
Copy link
Member

lilin90 commented Jul 14, 2020

@TomShawn Please resolve the conflicts.

@lilin90 lilin90 added status/require-change Needs the author to address comments. require-LGT1 Indicates that the PR requires an LGTM. labels Jul 14, 2020
@TomShawn
Copy link
Contributor Author

@lilin90 PTAL again, thanks!

@yikeke
Copy link
Contributor

yikeke commented Jul 14, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2020
@yikeke yikeke removed the require-LGT1 Indicates that the PR requires an LGTM. label Jul 14, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 14, 2020

/merge

@ti-srebot
Copy link
Contributor

@yikeke Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 14, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 14, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit decf86b into pingcap:master Jul 14, 2020
@TomShawn TomShawn deleted the devrm-categ-meta branch July 14, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@ran-huang ran-huang Awaiting requested review from ran-huang

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @lilin90 @yikeke @ti-srebot