Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mysql-compatibility.md #2790

Merged
merged 6 commits into from
Jun 16, 2020
Merged

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jun 11, 2020

What is changed, added or deleted? (Required)

Update mysql-compatibility.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 special-week PR from Document Special Week. labels Jun 11, 2020
@TomShawn TomShawn requested review from scsldb, tangenta and yikeke June 11, 2020 05:46
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Jun 11, 2020
Co-authored-by: tangenta <tangenta@126.com>
@yikeke yikeke requested review from lilin90 and removed request for yikeke June 11, 2020 10:02
@yikeke
Copy link
Contributor

yikeke commented Jun 11, 2020

Please help review this PR~ @lilin90

@yikeke yikeke self-requested a review June 11, 2020 10:03
@yikeke yikeke added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jun 12, 2020
@yikeke
Copy link
Contributor

yikeke commented Jun 12, 2020

Note that pingcap/docs-cn#3436 deleted inapplicable content in release-4.0. @TomShawn

@toutdesuite toutdesuite mentioned this pull request Jun 12, 2020
5 tasks
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
mysql-compatibility.md Outdated Show resolved Hide resolved
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jun 12, 2020
@TomShawn
Copy link
Contributor Author

Note that pingcap/docs-cn#3436 deleted inapplicable content in release-4.0. @TomShawn

OK, thanks for reminding me!

TomShawn and others added 3 commits June 12, 2020 18:40
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@TomShawn
Copy link
Contributor Author

@lilin90 All comments are addressed, PTAL again, thanks!

@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2020

@tangenta, @lilin90, @yikeke, @scsldb, PTAL.

@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2020

@TomShawn, please update your pull request.

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member

lilin90 commented Jun 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 2831
  • 2813

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 72ca480 into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2901

TomShawn added a commit that referenced this pull request Jun 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
5 tasks
@TomShawn TomShawn deleted the update-mysql-compati branch June 17, 2020 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants