Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysvar: add system variable tidb_opt_enable_hash_join #14905

Merged
merged 9 commits into from
Oct 7, 2023
Merged

sysvar: add system variable tidb_opt_enable_hash_join #14905

merged 9 commits into from
Oct 7, 2023

Conversation

coderplay
Copy link
Contributor

@coderplay coderplay commented Sep 22, 2023 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

Welcome @coderplay!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2023
@coderplay coderplay mentioned this pull request Sep 22, 2023
Merged
12 tasks
@coderplay
Copy link
Contributor Author

/cc @qw4990 @hawkingrei @chrysan @time-and-fate

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

@coderplay: GitHub didn't allow me to request PR reviews from the following users: chrysan, time-and-fate.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @qw4990 @hawkingrei @chrysan @time-and-fate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coderplay @Oreoxmt
Update system-variables.md
e0a8935 
Co-authored-by: Aolin <aolinz@outlook.com>
@hfxsd hfxsd self-assigned this Sep 27, 2023
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.4 This PR/issue applies to TiDB v7.4. and removed missing-translation-status This PR does not have translation status info. labels Sep 27, 2023
hfxsd
hfxsd reviewed Sep 27, 2023
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 27, 2023
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Sep 27, 2023
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
qw4990 and others added 3 commits September 27, 2023 10:03
@qw4990 @hfxsd
Update optimizer-hints.md
18a3d7a 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qw4990 @hfxsd
Update system-variables.md
3528068 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qw4990 @hfxsd
Update system-variables.md
9165081 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
qw4990
qw4990 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd changed the title Doc for system variable tidb_opt_enable_hash_join sysvar: add system variable tidb_opt_enable_hash_join Sep 27, 2023
@hfxsd hfxsd requested a review from qiancai September 27, 2023 08:18
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Sep 27, 2023
songrijie
songrijie approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2023

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

songrijie
songrijie approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2023

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qiancai
qiancai reviewed Oct 7, 2023
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@hfxsd @qiancai
Apply suggestions from code review
6c88144 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-27 03:19:48.865575282 +0000 UTC m=+417778.583917498: ☑️ agreed by hfxsd.
  • 2023-10-07 02:38:48.479504857 +0000 UTC m=+847126.066615003: ☑️ agreed by qiancai.

@hfxsd
Copy link
Collaborator

hfxsd commented Oct 7, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit b80e0c7 into pingcap:master Oct 7, 2023
9 checks passed
@hfxsd hfxsd added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 17, 2023
This was referenced Oct 17, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15125.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 17, 2023
@coderplay @ti-chi-bot
This is an automated cherry-pick of pingcap#14905
1c1b176 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Oct 17, 2023
@ti-chi-bot
sysvar: add system variable tidb_opt_enable_hash_join (#14905) (#15125
eb49eb2 
)
This was referenced Dec 1, 2023
Closed
Merged
@hfxsd hfxsd added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 1, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15583.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 1, 2023
@coderplay @ti-chi-bot
This is an automated cherry-pick of pingcap#14905
e5a8508 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 1, 2023
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 7, 2023
@ti-chi-bot
Do not merge until v6.5.6: sysvar: add system variable `tidb_opt_enab…
2db766a 
…le_hash_join` (#14905) (#15583)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt left review comments

@qw4990 qw4990 qw4990 approved these changes

@songrijie songrijie songrijie approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees

@hfxsd hfxsd

Labels
approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.4 This PR/issue applies to TiDB v7.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@coderplay @CLAassistant @hfxsd @ti-chi-bot @qw4990 @songrijie @Oreoxmt @qiancai