Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update system-variables.md: add mpp_version and mpp_exchange_compres.. #12387

Merged
merged 2 commits into from
Feb 10, 2023
Merged

update system-variables.md: add mpp_version and mpp_exchange_compres.. #12387

merged 2 commits into from
Feb 10, 2023

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Feb 6, 2023

What is changed, added or deleted? (Required)

add v6.6 docs for system-variables.md: add mpp_version and mpp_exchange_compres..

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 6, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2023
@TomShawn TomShawn self-assigned this Feb 6, 2023
@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.6 area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. labels Feb 6, 2023
solotzg
solotzg approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ran-huang
ran-huang approved these changes Feb 7, 2023
View reviewed changes
explain-mpp.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2023
@solotzg solotzg mentioned this pull request Feb 7, 2023
Closed
6 tasks
@TomShawn @ran-huang
Apply suggestions from code review
8f099bb 
Co-authored-by: Ran <huangran.alex@gmail.com>
@TomShawn
Copy link
Contributor Author

TomShawn commented Feb 8, 2023

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8f099bb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2023
@ti-chi-bot ti-chi-bot merged commit ec5258a into pingcap:master Feb 10, 2023
@TomShawn TomShawn deleted the mpp-exchange-compression branch February 10, 2023 06:38
@yahonda yahonda mentioned this pull request Mar 3, 2023
Merged
15 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 3, 2023
Merged
15 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 3, 2023
@yahonda @ti-chi-bot
Replace v6.6.6 with v6.6.0
c0da7c0 
Follow-up pingcap#12387
The Chinese version one looks correct pingcap/docs-cn#12921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solotzg solotzg solotzg approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees

@TomShawn TomShawn

Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @ti-chi-bot @solotzg @ran-huang