Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

en: update doc for deploying TiDB cluster on AWS EKS #49

Merged
merged 8 commits into from
Mar 27, 2020
Merged

en: update doc for deploying TiDB cluster on AWS EKS #49

merged 8 commits into from
Mar 27, 2020

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

Update doc for deploying TiDB cluter on AWS EKS.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version, including v1.1 changes for now)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added priority/P2 The issue has P2 priority. translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh. labels Mar 26, 2020
DanielZhangQD
DanielZhangQD reviewed Mar 26, 2020
View reviewed changes
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor Author

@DanielZhangQD Comments addressed. PTAL, thanks~

yikeke
yikeke reviewed Mar 27, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Outdated Show resolved Hide resolved
en/deploy-on-aws-eks.md Show resolved Hide resolved
@yikeke yikeke changed the title en: update doc for deploying TiDB cluter on AWS EKS en: update doc for deploying TiDB cluster on AWS EKS Mar 27, 2020
ran-huang and others added 2 commits March 27, 2020 16:21
@ran-huang @yikeke
Apply suggestions from coco
39c9f00 
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
@ran-huang
Merge branch 'master' into deploy-aws-eks
f165c60
@ran-huang
Copy link
Contributor Author

@yikeke Comments addressed. PTAL again~

yikeke
yikeke approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang merged commit 5e15dfa into pingcap:master Mar 27, 2020
@ran-huang ran-huang deleted the deploy-aws-eks branch March 27, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD left review comments

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
priority/P2 The issue has P2 priority. translation/from-zh This PR is translated from a PR in docs-tidb-operator/zh.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @DanielZhangQD @yikeke