Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: update mydumper backup docs #273

Merged
merged 7 commits into from
May 15, 2020
Merged

Conversation

onlymellb
Copy link
Contributor

@onlymellb onlymellb commented May 12, 2020

What is changed, added or deleted? (Required)

Update CRD backup docs with mydumper.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

pingcap/tidb-operator#2435
pingcap/tidb-operator#2407

  • This PR is translated from:
  • Other reference link(s):

@ran-huang
Copy link
Contributor

Please fix the CI failure and then involve a tech reviewer.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD added the needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. label May 14, 2020
zh/backup-to-gcs.md Outdated Show resolved Hide resolved
zh/backup-to-gcs.md Outdated Show resolved Hide resolved
zh/backup-to-s3.md Outdated Show resolved Hide resolved
zh/backup-to-s3.md Outdated Show resolved Hide resolved
@ran-huang ran-huang added the translation/doing This PR’s assignee is translating this PR. label May 14, 2020
@ran-huang ran-huang self-assigned this May 14, 2020
@ran-huang
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit 1a919ce into pingcap:master May 15, 2020
sre-bot pushed a commit to sre-bot/docs-tidb-operator that referenced this pull request May 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 15, 2020

cherry pick to release-1.1 in PR #283

DanielZhangQD pushed a commit that referenced this pull request May 15, 2020
Co-authored-by: onlymellb <luolibin@pingcap.com>
@lilin90 lilin90 changed the title zh: Update mydumper backup docs zh: update mydumper backup docs May 15, 2020
@DanielZhangQD DanielZhangQD added the v1.1 This PR/issue applies to TiDB Operator v1.1. label May 20, 2020
@ran-huang ran-huang mentioned this pull request May 26, 2020
3 tasks
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 26, 2020
@@ -128,6 +139,21 @@ GCS 支持以下几种 bucket ACL 策略:
* `.spec.from.port`:待备份 TiDB 集群的访问端口。
* `.spec.from.user`:待备份 TiDB 集群的访问用户。
* `.spec.from.tidbSecretName`:待备份 TiDB 集群所需凭证的 secret。
* `.spec.gcs.bucket`:存储数据的 bucket 名字。
* `.spec.gcs.prefix`:这个字段可以省略,如果设置了这个字段,则会使用这个字段来拼接在远端存储的存储路径 `s3://${.spec.s3.bucket}/${.spec.s3.prefix}/backupName`。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onlymellb s3://${.spec.s3.bucket}/${.spec.s3.prefix}/backupName 里并没有出现 .spec.gcs.prefix 这个字段哦,是不是写错了呢?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v1.1 This PR/issue applies to TiDB Operator v1.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants