Skip to content

Commit

Permalink
Merge branch 'master' into improveImportDoc
Browse files Browse the repository at this point in the history
  • Loading branch information
BinChen authored Dec 7, 2020
2 parents eb38cc9 + 8617387 commit f48f8f1
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions en/configure-a-tidb-cluster.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,14 +167,14 @@ The deployed cluster topology by default has three PD Pods, three TiKV Pods, and

#### Enable TiFlash

If you want to enable TiFlash in the cluster, configure `spec.pd.config.replication.enable-placement-rules` to `true` and configure `spec.tiflash` in the `${cluster_name}/tidb-cluster.yaml` file as follows:
If you want to enable TiFlash in the cluster, configure `spec.pd.config.replication.enable-placement-rules: true` and configure `spec.tiflash` in the `${cluster_name}/tidb-cluster.yaml` file as follows:

```yaml
pd:
config:
...
replication:
enable-placement-rules: "true"
enable-placement-rules: true
...
tiflash:
baseImage: pingcap/tiflash
Expand Down
2 changes: 1 addition & 1 deletion en/deploy-tiflash.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ TiFlash supports mounting multiple Persistent Volumes (PVs). If you want to conf
>
> Since TiDB Operator will mount PVs automatically in the **order** of the items in the `storageClaims` list, if you need to add more disks to TiFlash, make sure to append the new item only to the **end** of the original items, and **DO NOT** modify the order of the original items.

To add TiFlash component to an existing TiDB cluster, you need to set `replication.enable-placement-rules` to `true` in PD. After you add the TiFlash configuration in `TidbCluster` by taking the above steps, TiDB Operator automatically configures `replication.enable-placement-rules: "true"` in PD.
To add TiFlash component to an existing TiDB cluster, you need to set `replication.enable-placement-rules: true` in PD. After you add the TiFlash configuration in `TidbCluster` by taking the above steps, TiDB Operator automatically configures `replication.enable-placement-rules: true` in PD.

If the server does not have an external network, refer to [deploy the TiDB cluster](deploy-on-general-kubernetes.md#deploy-the-tidb-cluster) to download the required Docker image on the machine with an external network and upload it to the server.

Expand Down
4 changes: 2 additions & 2 deletions zh/configure-a-tidb-cluster.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,14 +162,14 @@ PD 和 TiKV 支持配置 `mountClusterClientSecret`,建议配置 `spec.pd.moun

#### 部署 TiFlash

如果要在集群中开启 TiFlash,需要在 `${cluster_name}/tidb-cluster.yaml` 文件中配置 `spec.pd.config.replication.enable-placement-rules: "true"`,并配置 `spec.tiflash`:
如果要在集群中开启 TiFlash,需要在 `${cluster_name}/tidb-cluster.yaml` 文件中配置 `spec.pd.config.replication.enable-placement-rules: true`,并配置 `spec.tiflash`:

```yaml
pd:
config:
...
replication:
enable-placement-rules: "true"
enable-placement-rules: true
...
tiflash:
baseImage: pingcap/tiflash
Expand Down
2 changes: 1 addition & 1 deletion zh/deploy-tiflash.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ TiFlash 支持挂载多个 PV,如果要为 TiFlash 配置多个 PV,可以在
>
> 由于 TiDB Operator 会按照 `storageClaims` 列表中的配置**按顺序**自动挂载 PV,如果需要为 TiFlash 增加磁盘,请确保只在列表原有配置**最后添加**,并且**不能**修改列表中原有配置的顺序。

新增部署 TiFlash 需要 PD 配置 `replication.enable-placement-rules: "true"`,通过上述步骤在 TidbCluster 中增加 TiFlash 配置后,TiDB Operator 会自动为 PD 配置 `replication.enable-placement-rules: "true"`。
新增部署 TiFlash 需要 PD 配置 `replication.enable-placement-rules: true`,通过上述步骤在 TidbCluster 中增加 TiFlash 配置后,TiDB Operator 会自动为 PD 配置 `replication.enable-placement-rules: true`。

如果服务器没有外网,请参考[部署 TiDB 集群](deploy-on-general-kubernetes.md#部署-tidb-集群)在有外网的机器上将用到的 Docker 镜像下载下来并上传到服务器上。

Expand Down

0 comments on commit f48f8f1

Please sign in to comment.