Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update doc for IndexMerge GA #8082

Merged
merged 18 commits into from
Jan 7, 2022
Merged

update doc for IndexMerge GA #8082

merged 18 commits into from
Jan 7, 2022

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Dec 29, 2021 •
edited by TomShawn
Loading

Signed-off-by: guo-shaoge shaoge1994@163.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@guo-shaoge
update doc for IndexMerge GA
647f8d7 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 29, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn December 29, 2021 08:56
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 29, 2021
@TomShawn TomShawn added area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. translation/doing This PR’s assignee is translating this PR. v5.4 This PR/issue applies to TiDB v5.4. and removed missing-translation-status This PR does not have translation status info. labels Dec 29, 2021
@TomShawn
Copy link
Contributor

@guo-shaoge Please involve a technical review and a PM review. Thanks!

@guo-shaoge
fix
c98d3b1 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@TomShawn TomShawn assigned guo-shaoge and unassigned shichun-0415 Dec 29, 2021
@guo-shaoge
fix
ea2131e 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
TomShawn
TomShawn reviewed Dec 29, 2021
View reviewed changes
@TomShawn TomShawn mentioned this pull request Dec 30, 2021
Merged
15 tasks
@guo-shaoge
fix
e8d24ed 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Merge branch 'index_merge_doc' of github.com:guo-shaoge/docs-cn into …
f95c582 
…index_merge_doc
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2022
@guo-shaoge
Copy link
Contributor Author

/cc @XuHuaiyu

@ti-chi-bot ti-chi-bot requested a review from XuHuaiyu January 4, 2022 06:13
@guo-shaoge
Copy link
Contributor Author

/cc @moyun

@ti-chi-bot
Copy link
Member

@guo-shaoge: GitHub didn't allow me to request PR reviews from the following users: moyun.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @moyun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TomShawn TomShawn removed the translation/doing This PR’s assignee is translating this PR. label Jan 4, 2022
XuHuaiyu
XuHuaiyu reviewed Jan 6, 2022
View reviewed changes
@guo-shaoge
fix comment
d5ec98b 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
XuHuaiyu
XuHuaiyu approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shichun-0415
shichun-0415 reviewed Jan 6, 2022
View reviewed changes
moyun
moyun reviewed Jan 6, 2022
View reviewed changes
guo-shaoge and others added 5 commits January 7, 2022 13:56
@guo-shaoge @shichun-0415
Update optimizer-hints.md
2dfbf94 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@guo-shaoge @shichun-0415
Update system-variables.md
7764f10 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@guo-shaoge
fix comment(explain-index-merge.md)
a262411 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
IndexMerge -> 索引合并
481733f 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Merge branch 'index_merge_doc' of github.com:guo-shaoge/docs-cn into …
de01929 
…index_merge_doc
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2022
shichun-0415
shichun-0415 approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2022
guo-shaoge and others added 4 commits January 7, 2022 15:33
@guo-shaoge @shichun-0415
Update explain-index-merge.md
8fda823 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@guo-shaoge
fix sql case
a272eef 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Merge branch 'index_merge_doc' of github.com:guo-shaoge/docs-cn into …
35ab497 
…index_merge_doc
@guo-shaoge
fix lint
ce4b676 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
qiancai
qiancai reviewed Jan 7, 2022
View reviewed changes
@shichun-0415 @qiancai
Apply suggestions from code review
5063b6e 
Co-authored-by: Grace Cai <qqzczy@126.com>
shichun-0415
shichun-0415 reviewed Jan 7, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 7, 2022
@qiancai
Copy link
Collaborator

qiancai commented Jan 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 56e9e9a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 7, 2022
@ti-chi-bot ti-chi-bot merged commit 6c7444e into pingcap:master Jan 7, 2022
@shichun-0415 shichun-0415 mentioned this pull request Jan 10, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moyun moyun moyun left review comments

@TomShawn TomShawn TomShawn left review comments

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@qiancai qiancai qiancai approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees

@guo-shaoge guo-shaoge

@shichun-0415 shichun-0415

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@guo-shaoge @ti-chi-bot @TomShawn @qiancai @moyun @XuHuaiyu @shichun-0415