Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system variables: update tidb_enable_noop_functions behavior #7162

Merged
merged 1 commit into from
Oct 9, 2021
Merged

system variables: update tidb_enable_noop_functions behavior #7162

merged 1 commit into from
Oct 9, 2021

Conversation

unconsolable
Copy link
Contributor

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Document tidb_enable_noop_functions controls system variable sql_auto_is_null, which is introduced by pingcap/tidb#28247

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@unconsolable
system variables: document tidb_enable_noop_functions controls sql_au…
66b565b 
…to_is_null

Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Sep 23, 2021
@ti-chi-bot
Copy link
Member

Welcome @unconsolable!

It looks like this is your first PR to pingcap/docs-cn 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-cn. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2021
@unconsolable unconsolable mentioned this pull request Sep 23, 2021
Merged
13 tasks
@TomShawn TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. and removed missing-translation-status This PR does not have translation status info. labels Sep 23, 2021
@TomShawn TomShawn self-assigned this Sep 24, 2021
@TomShawn TomShawn added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. translation/doing This PR’s assignee is translating this PR. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 24, 2021
@TomShawn TomShawn assigned unconsolable and unassigned TomShawn Sep 24, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Oct 9, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Oct 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 66b565b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2021
@ti-chi-bot ti-chi-bot merged commit 3df6ce6 into pingcap:master Oct 9, 2021
@unconsolable unconsolable deleted the docs-add-sysvar branch October 9, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees

@unconsolable unconsolable

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-future-release This PR only applies to master for now and might cherry-pick to a future release. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unconsolable @ti-chi-bot @TomShawn