Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add desc of "Storage Write Stall" row in the TiFlash grafana #7161

Merged
merged 5 commits into from
Sep 29, 2021
Merged

Add desc of "Storage Write Stall" row in the TiFlash grafana #7161

merged 5 commits into from
Sep 29, 2021

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Sep 23, 2021 •
edited
Loading

Signed-off-by: JaySon-Huang tshent@qq.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@JaySon-Huang
Add desc of "Storage Write Stall" row in the TiFlash grafana
20d7d3b 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2021
@JaySon-Huang JaySon-Huang mentioned this pull request Sep 23, 2021
Merged
13 tasks
@JaySon-Huang JaySon-Huang self-assigned this Sep 23, 2021
@TomShawn TomShawn added area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. sig/docs Indicates that the Issue or PR belongs to the docs SIG. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 23, 2021
@TomShawn
Copy link
Contributor

@JaySon-Huang Could you please involve one or two technical reviewers? Thanks!

@JaySon-Huang @TomShawn
Apply suggestions from code review
4817024 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2021
@flowbehappy
Copy link
Contributor

LGTM

TomShawn
TomShawn approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2021
TomShawn
TomShawn approved these changes Sep 26, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shichun-0415
shichun-0415 reviewed Sep 26, 2021
View reviewed changes
tiflash/monitor-tiflash.md Outdated Show resolved Hide resolved
tiflash/monitor-tiflash.md Outdated Show resolved Hide resolved
@TomShawn @shichun-0415
Update tiflash/monitor-tiflash.md
b26e8f5 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@TomShawn @shichun-0415
Update tiflash/monitor-tiflash.md
675b031 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 29, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 675b031

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 29, 2021
This was referenced Sep 29, 2021
Merged
Merged
Merged
@ti-chi-bot ti-chi-bot merged commit 24b314c into pingcap:master Sep 29, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 29, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7219.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 29, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7220.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 29, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7221.

ti-chi-bot added a commit that referenced this pull request Sep 30, 2021
@ti-chi-bot
Add desc of "Storage Write Stall" row in the TiFlash grafana (#7161) (#…
eaee50d 
…7221)
ti-chi-bot added a commit that referenced this pull request Sep 30, 2021
@ti-chi-bot
Add desc of "Storage Write Stall" row in the TiFlash grafana (#7161) (#…
ebb6df8 
…7220)
ti-chi-bot added a commit that referenced this pull request Sep 30, 2021
@ti-chi-bot
Add desc of "Storage Write Stall" row in the TiFlash grafana (#7161) (#…
4e5bde0 
…7219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@JaySon-Huang JaySon-Huang

Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JaySon-Huang @ti-chi-bot @TomShawn @flowbehappy @shichun-0415