Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the default value of tidb_stmt_summary_max_stmt_count #6718

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Update the default value of tidb_stmt_summary_max_stmt_count #6718

merged 3 commits into from
Jul 23, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jul 23, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Update the default value of tidb_stmt_summary_max_stmt_count to 3000

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2021
@TomShawn TomShawn requested a review from crazycs520 July 23, 2021 06:58
@TomShawn TomShawn self-assigned this Jul 23, 2021
@TomShawn TomShawn added needs-cherry-pick-master Should cherry pick this PR to master branch. needs-cherry-pick-release-5.0 require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Jul 23, 2021
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 23, 2021
TomShawn
TomShawn commented Jul 23, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
crazycs520
crazycs520 reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cd48623

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021
@ti-chi-bot ti-chi-bot merged commit c9dd5a1 into pingcap:release-4.0 Jul 23, 2021
@TomShawn TomShawn deleted the stmt-defaul branch July 23, 2021 07:08
@TomShawn TomShawn added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jul 23, 2021
@TomShawn TomShawn mentioned this pull request Jul 23, 2021
Merged
11 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 23, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#6718
7008459 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6719.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 23, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#6718
905ea43 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6720.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
11 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 23, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#6718
f206675 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6721.

This was referenced Jul 23, 2021
Merged
Merged
Merged
ti-chi-bot added a commit that referenced this pull request Jul 23, 2021
@ti-chi-bot
Update the default value of tidb_stmt_summary_max_stmt_count (#6718) (#…
364f4b6 
…6719)
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@ti-chi-bot @3AceShowHand
Update the default value of tidb_stmt_summary_max_stmt_count (pingcap…
3ab48a2 
…#6718) (pingcap#6719)
ti-chi-bot added a commit that referenced this pull request Jul 30, 2021
@ti-chi-bot
Update the default value of tidb_stmt_summary_max_stmt_count (#6718) (#…
2ed776c 
…6721)
ti-chi-bot added a commit that referenced this pull request Oct 9, 2021
@ti-chi-bot
Update the default value of tidb_stmt_summary_max_stmt_count (#6718) (#…
2ec7e72 
…6720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees

@TomShawn TomShawn

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-master Should cherry pick this PR to master branch. require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-chi-bot @crazycs520