Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two docs for getting started with HTAP and exploring HTAP #6613

Merged
merged 36 commits into from
Jul 19, 2021
Merged

Add two docs for getting started with HTAP and exploring HTAP #6613

merged 36 commits into from
Jul 19, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jul 5, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Add two docs for getting started with HTAP and exploring HTAP.

The co-authors of the two docs include @superlzs0476 and @moyun. And thanks @lilinghai for testing the getting started guide of HTAP.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 5, 2021 09:12
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 5, 2021
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Jul 5, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 5, 2021
@qiancai qiancai changed the title Add two docs for getting started with HTAP and exploring HTAP [WIP]: Add two docs for getting started with HTAP and exploring HTAP Jul 5, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 5, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 5, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 5, 2021
qiancai
qiancai commented Jul 5, 2021
View reviewed changes
explore_htap.md Outdated Show resolved Hide resolved
qiancai
qiancai commented Jul 5, 2021
View reviewed changes
quick-start-with-htap.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2021
TomShawn
TomShawn approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor comments~

explore-htap.md Show resolved Hide resolved
explore-htap.md Outdated Show resolved Hide resolved
explore-htap.md Outdated Show resolved Hide resolved
explore-htap.md Outdated Show resolved Hide resolved
explore-htap.md Outdated Show resolved Hide resolved
quick-start-with-htap.md Outdated Show resolved Hide resolved
quick-start-with-htap.md Outdated Show resolved Hide resolved
explore-htap.md Outdated Show resolved Hide resolved
quick-start-with-htap.md Outdated Show resolved Hide resolved
quick-start-with-htap.md Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • superlzs0476

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 14, 2021
moyun
moyun reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@moyun moyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lilyjazz
lilyjazz approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@lilyjazz lilyjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@lilyjazz: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Collaborator Author

qiancai commented Jul 19, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eab6bf0

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jul 19, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Jul 19, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bcf274e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@ti-chi-bot ti-chi-bot merged commit d66152b into pingcap:master Jul 19, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@qiancai @3AceShowHand
Add two docs for getting started with HTAP and exploring HTAP (pingca…
66e2b3d 
…p#6613)
@qiancai qiancai assigned en-jin19 and unassigned qiancai Aug 13, 2021
@en-jin19 en-jin19 added the v5.2 This PR/issue applies to TiDB v5.2. label Aug 16, 2021
@en-jin19 en-jin19 mentioned this pull request Aug 22, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 22, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 27, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moyun moyun moyun left review comments

@lilyjazz lilyjazz lilyjazz approved these changes

@LiSong0214 LiSong0214 LiSong0214 approved these changes

@TomShawn TomShawn TomShawn approved these changes

@superlzs0476 superlzs0476 superlzs0476 approved these changes

@lilinghai lilinghai Awaiting requested review from lilinghai

@ilovesoup ilovesoup Awaiting requested review from ilovesoup

Assignees

@en-jin19 en-jin19

Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.2 This PR/issue applies to TiDB v5.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@qiancai @ti-chi-bot @moyun @lilyjazz @LiSong0214 @TomShawn @superlzs0476 @en-jin19