Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: add mysql sink user privilege #6400

Merged
merged 5 commits into from
Jul 15, 2021
Merged

ticdc: add mysql sink user privilege #6400

merged 5 commits into from
Jul 15, 2021

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Jun 3, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add mysql sink privilege in TiCDC FAQ

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@amyangfei amyangfei added the area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. label Jun 3, 2021
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2021
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Jun 3, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 3, 2021
@TomShawn TomShawn requested a review from zier-one June 3, 2021 11:20
@TomShawn
Copy link
Contributor

@amyangfei Any update?

amyangfei and others added 4 commits July 5, 2021 18:13
@amyangfei @TomShawn
Update ticdc/troubleshoot-ticdc.md
7daea0f 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@amyangfei @TomShawn
Update ticdc/troubleshoot-ticdc.md
0503b62 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@amyangfei @TomShawn
Update ticdc/troubleshoot-ticdc.md
f390209 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@amyangfei @TomShawn
Update ticdc/troubleshoot-ticdc.md
a59442e 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@TomShawn: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added the sig/docs Indicates that the Issue or PR belongs to the docs SIG. label Jul 5, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
@TomShawn TomShawn added type/enhancement The issue or PR belongs to an enhancement. and removed needs-cherry-pick-release-4.0 labels Jul 14, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a59442e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021
@ti-chi-bot ti-chi-bot merged commit 937c40e into pingcap:master Jul 15, 2021
@amyangfei amyangfei deleted the cdc-sink-privilege branch July 15, 2021 16:17
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@amyangfei @3AceShowHand
ticdc: add mysql sink user privilege (pingcap#6400)
526f528
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Aug 2, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @TomShawn @ti-chi-bot @Liuxiaozhen12