Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the swappiness parameter #6377

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

glkappe
Copy link
Contributor

@glkappe glkappe commented May 31, 2021

repeat

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 31, 2021 09:24
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2021
@glkappe
Copy link
Contributor Author

glkappe commented May 31, 2021

There is another problem. The modification of sysctl conf is in the form of echo. There is a high probability that the parameters will be repeated. The previous parameter takes effect. How to modify the way the parameters take effect? ​​When a large cluster is deployed, it is not very convenient

@TomShawn
Copy link
Contributor

/cc @pepezzzz @King-Dylan

@ti-chi-bot ti-chi-bot requested a review from King-Dylan May 31, 2021 11:16
@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: pepezzzz.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pepezzzz @King-Dylan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TomShawn TomShawn added needs-cherry-pick-release-5.0 require-LGT1 Indicates that the PR requires an LGTM. translation/doing This PR’s assignee is translating this PR. labels May 31, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 31, 2021
@King-Dylan
Copy link
Contributor

目的是为了修改参数,如果 echo 有问题那可以改成 vim 进去手工修改添加的方式。这个 pr 这里只是删了 swappiness 参数。

@TomShawn
Copy link
Contributor

TomShawn commented Jun 2, 2021

目的是为了修改参数,如果 echo 有问题那可以改成 vim 进去手工修改添加的方式。这个 pr 这里只是删了 swappiness 参数。

@glkappe Any update?

@glkappe
Copy link
Contributor Author

glkappe commented Jul 5, 2021

目的是为了修改参数,如果 echo 有问题那可以改成 vim 进去手工修改添加的方式。这个 pr 这里只是删了 swappiness 参数。

优化 quick start,让它能复制粘贴不需要修改就可以执行,如果只是为了让用户「你应该修改这个」,那这个价值就很低。

目的还是如何优化这个 ,真实使用遇到的很麻烦的问题。

@King-Dylan
Copy link
Contributor

我明白你意思,但是你这个 pr 只是删了一行而已

@dveeden
Copy link
Contributor

dveeden commented Jul 5, 2021

If this gets removed from the docs then tiup cluster check ... should also be modified.
https://github.com/pingcap/tiup/blob/45e4471d4c627ff367253a69ef3f9c13bf79ddbe/pkg/cluster/operation/check.go#L407-L416

@King-Dylan
Copy link
Contributor

from glkappe 删了这一行是因为前面步骤已经执行,重复了

@ti-chi-bot
Copy link
Member

@King-Dylan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented Jul 6, 2021

If this gets removed from the docs then tiup cluster check ... should also be modified.
https://github.com/pingcap/tiup/blob/45e4471d4c627ff367253a69ef3f9c13bf79ddbe/pkg/cluster/operation/check.go#L407-L416

@lucklove @AstroProfundis FYI

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0349427

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2021
@ti-chi-bot ti-chi-bot merged commit e4a4917 into pingcap:master Jul 6, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6624.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6625.

@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 16, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants