-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the swappiness parameter #6377
Conversation
There is another problem. The modification of sysctl conf is in the form of |
/cc @pepezzzz @King-Dylan |
@TomShawn: GitHub didn't allow me to request PR reviews from the following users: pepezzzz. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
目的是为了修改参数,如果 echo 有问题那可以改成 vim 进去手工修改添加的方式。这个 pr 这里只是删了 swappiness 参数。 |
@glkappe Any update? |
优化 quick start,让它能复制粘贴不需要修改就可以执行,如果只是为了让用户「你应该修改这个」,那这个价值就很低。 目的还是如何优化这个 ,真实使用遇到的很麻烦的问题。 |
我明白你意思,但是你这个 pr 只是删了一行而已 |
If this gets removed from the docs then |
from glkappe 删了这一行是因为前面步骤已经执行,重复了 |
@King-Dylan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0349427
|
In response to a cherrypick label: new pull request created: #6624. |
In response to a cherrypick label: new pull request created: #6625. |
repeat
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?