Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiCDC: add information about Unified Sorter #4959

Merged
merged 14 commits into from
Dec 21, 2020

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Nov 25, 2020

What is changed, added or deleted? (Required)

  • Added explanation about the --sort-engine parameter of a TiCDC changefeed.
  • Added information about Unified Sorter to the TiCDC trouble shooting FAQs.

Which TiDB version(s) do your changes apply to? (Required)

  • master
  • v4.0.9
  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn self-assigned this Nov 25, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/medium Changes of a medium size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Nov 25, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, PTAL.

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2020
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on formats and wording

ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/troubleshoot-ticdc.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

TomShawn commented Dec 1, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2020
@TomShawn TomShawn added status/DNM and removed status/PTAL This PR is ready for reviewing. labels Dec 1, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, @ti-srebot, PTAL.

> + 目前文件排序功能的处理能力有限。如果单表数据量过多导致文件排序失败,可以修改 TiCDC 任务配置过滤掉这张表,通过其他备份恢复工具例如 BR 恢复这张表之后再继续同步该表。
> + TiCDC 从 4.0.9 版本起支持 Unified Sorter 排序引擎。
> + TiCDC(4.0 发布版本)还不支持动态修改排序引擎。
> + 目前 Unified Sorter 排序引擎为实验特性,在数据表较多 (>= 100) 时可能出现性能问题,影响同步速度,故不建议在生产环境中长期使用。开启 Unified Sorter 前请保证各 TiCDC 节点机器上有足够硬盘空间。如果积攒的数据总量有可能超过 1 TB,则不建议使用 TiCDC 进行同步。
Copy link
Contributor

@TomShawn TomShawn Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"不建议在生产环境中长期使用" 表示 "可以在生产环境中短期使用" 吗?

@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 4, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, @ti-srebot, PTAL.

@TomShawn TomShawn mentioned this pull request Dec 7, 2020
10 tasks
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, @ti-srebot, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, @ti-srebot, PTAL.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

{{< copyable "shell-regular" >}}

```shell
cdc cli changefeed create --pd=http://10.0.10.25:2379 --start-ts=415238226621235200 --sink-uri="mysql://root:123456@127.0.0.1:3306/" --sort-engine="file" --sort-dir="/data/cdc/sort"
cdc cli changefeed create --pd=http://10.0.10.25:2379 --start-ts=415238226621235200 --sink-uri="mysql://root:123456@127.0.0.1:3306/" --sort-engine="unified" --sort-dir="/data/cdc/sort"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not cdc cli changefeed update? So we need to make sure using the right start ts when creating a new changefeed.

@ti-srebot
Copy link
Contributor

@amyangfei, @ti-srebot, PTAL.

@ti-srebot
Copy link
Contributor

@amyangfei, PTAL.

@TomShawn TomShawn merged commit 3a0228e into pingcap:master Dec 21, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Dec 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5138

TomShawn added a commit that referenced this pull request Dec 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Zixiong Liu <liuzixiong@pingcap.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium Changes of a medium size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants