Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanation about two kafka parameters #4951

Merged
merged 11 commits into from
Dec 21, 2020
Merged

Add explanation about two kafka parameters #4951

merged 11 commits into from
Dec 21, 2020

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Nov 24, 2020

What is changed, added or deleted? (Required)

  • Added documentation of max-batch-size.
  • Added extra explanation about max-message-bytes.

Which TiDB version(s) do your changes apply to? (Required)

  • 4.0.9
  • master
  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

TomShawn
TomShawn reviewed Nov 25, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Nov 25, 2020
@TomShawn
Copy link
Contributor

@liuzix If the content applies to v4.0.9 or later, we shall merge this PR after v4.0.9 is released.

@liuzix
Copy link
Contributor Author

liuzix commented Nov 25, 2020

@liuzix If the content applies to v4.0.9 or later, we shall merge this PR after v4.0.9 is released.

Yes, we can do that.

amyangfei
amyangfei reviewed Nov 25, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
@liuzix @amyangfei
Update ticdc/manage-ticdc.md
0bcc49a 
Co-authored-by: amyangfei <amyangfei@gmail.com>
amyangfei
amyangfei reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, PTAL.

TomShawn
TomShawn reviewed Dec 1, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Dec 1, 2020
View reviewed changes
ticdc/manage-ticdc.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

TomShawn commented Dec 1, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 1, 2020
@TomShawn TomShawn added status/DNM and removed status/PTAL This PR is ready for reviewing. labels Dec 1, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, @ti-srebot, PTAL.

@TomShawn TomShawn self-assigned this Dec 4, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 4, 2020
@TomShawn TomShawn mentioned this pull request Dec 4, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, @ti-srebot, PTAL.

1 similar comment
@ti-srebot
Copy link
Contributor

@TomShawn, @amyangfei, @ti-srebot, PTAL.

@TomShawn TomShawn merged commit 8ff3ca4 into pingcap:master Dec 21, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Dec 21, 2020
@liuzix @ti-srebot
cherry pick pingcap#4951 to release-4.0
c6cbc60 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 21, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5141

TomShawn pushed a commit that referenced this pull request Dec 21, 2020
@ti-srebot @liuzix
cherry pick #4951 to release-4.0 (#5141)
214b778 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Zixiong Liu <liuzixiong@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 21, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@TomShawn TomShawn TomShawn left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzix @CLAassistant @TomShawn @ti-srebot @amyangfei @Joyinqin