reference: add a description of max-index-length #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
AilinKid
reviewed
Apr 15, 2020
|
|
||
| ### `max-index-length` | ||
|
|
||
| + 用于设置新建索引的长度限制。 |
There was a problem hiding this comment.
should put the difference with MySQL's link here?
There was a problem hiding this comment.
+1, we can add a little more explainations here.
There was a problem hiding this comment.
MySQL does not have this item.
TomShawn
reviewed
Apr 15, 2020
|
|
||
| + 用于设置新建索引的长度限制。 | ||
| + 默认值：3072 | ||
| + 单位：byte，目前的合法值范围 [3072, 3072*4]。MySQL 和 TiDB v3.0.11 之前版本没有此配置项，不过都对新建索引的长度做了限制。MySQL 对此的长度限制为 3072，TiDB 在 v3.0.7 以及之前版本此值为 3072*4。为了与 MySQL 和 TiDB 之前版本的兼容，添加了此配置项。 |
There was a problem hiding this comment.
@zimulala v3.0.11 and v3.0.7, the versions seem inconsistent. If this is correct, I may wonder:
- what's the default length limit between v3.0.7 and v3.0.11.
- when this limit (default value) changed from 3072*4 to 3072.
There was a problem hiding this comment.
what's the default length limit between v3.0.7 and v3.0.11.
when this limit (default value) changed from 3072*4 to 3072.
3.0.11
There was a problem hiding this comment.
Suggested change
| + 单位：byte，目前的合法值范围 [3072, 3072*4]。MySQL 和 TiDB v3.0.11 之前版本没有此配置项，不过都对新建索引的长度做了限制。MySQL 对此的长度限制为 3072，TiDB 在 v3.0.7 以及之前版本此值为 3072*4。为了与 MySQL 和 TiDB 之前版本的兼容，添加了此配置项。 | |
| + 单位：byte | |
| + 目前的合法值范围 `[3072, 3072*4]`。MySQL 和 TiDB v3.0.11 之前版本（不包含 v3.0.11）没有此配置项，不过都对新建索引的长度做了限制。MySQL 对此的长度限制为 `3072`，TiDB 在 v3.0.7 以及之前版本该值为 `3072*4`，在 v3.0.7 之后的该值为 `3072`。为了与 MySQL 和 TiDB 之前版本的兼容，添加了此配置项。 |
zimulala
force-pushed
the
max-index-length
branch
from
ed4f083
to
08bf0ad
Compare
zimulala
force-pushed
the
max-index-length
branch
from
6024f94
to
de6fff6
Compare
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Apr 15, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
5 tasks
|
cherry pick to release-3.0 in PR #2764 |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Apr 15, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
5 tasks
|
cherry pick to release-3.1 in PR #2765 |
sre-bot
pushed a commit
to sre-bot/docs-cn
that referenced
this pull request
Apr 15, 2020
5 tasks
|
cherry pick to release-4.0 in PR #2766 |
TomShawn
pushed a commit
that referenced
this pull request
Apr 15, 2020
TomShawn
pushed a commit
that referenced
this pull request
Apr 15, 2020
TomShawn
pushed a commit
that referenced
this pull request
Apr 15, 2020
5 tasks
TomShawn
added
translation/done
This was referenced Apr 21, 2020
rleungx
pushed a commit
to rleungx/docs-cn
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Add a description of
max-index-length.Related to pingcap/tidb#15012.
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?