reference: add documentation for statement summary #1923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Ian <ArGregoryIan@gmail.com>
Co-Authored-By: WangXiangUSTC <wx347249478@gmail.com>
Co-Authored-By: WangXiangUSTC <wx347249478@gmail.com>
Co-Authored-By: WangXiangUSTC <wx347249478@gmail.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
…cap#1861) * Add notes about "cluster-id mismatch" * Update dev/tidb-in-kubernetes/troubleshoot.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update dev/tidb-in-kubernetes/troubleshoot.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update dev/tidb-in-kubernetes/troubleshoot.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * sync dev to v3.0
dcalvin
reviewed
Oct 11, 2019
|
|
||
| `events_statement_summary_by_digest` 是 `performance_schema` 里的一张系统表。顾名思义，它把 SQL 按 digest 分组，统计每一组的 SQL 信息。 | ||
|
|
||
| digest 是什么呢？它与 slow log 里的 digest 一样，是把 SQL 规范化后算出的唯一标识符。 |
There was a problem hiding this comment.
Suggest combine these several sentences into one paragraph. And also "digest 是什么呢？" sounds too casual and does not match our documentation style (the tone sounds suitable for a presentation or blog article)
Suggested change
| digest 是什么呢？它与 slow log 里的 digest 一样，是把 SQL 规范化后算出的唯一标识符。 | |
| 此处的 digest 与 slow log 里的 digest 一样，是把 SQL 规范化后算出的唯一标识符。 |
…iguration (pingcap#1856) * Update hardware-recommendations.md * Update hardware-recommendations.md * Update hardware-recommendations.md * Update hardware-recommendations.md * modify wording
dcalvin
reviewed
Oct 12, 2019
|
|
||
| # Statement Summary Table | ||
|
|
||
| ## 简介 |
There was a problem hiding this comment.
On second thought, we don't need this title. Please remove it. Thanks.
dcalvin
reviewed
Oct 12, 2019
|
|
||
| # Statement Summary Table | ||
|
|
||
| ## 简介 |
…s-cn into add_statements_doc
…w832/docs-cn into add_statements_doc" This reverts commit 3c4d50e, reversing changes made to 92e85be. revert Merge
dcalvin
reviewed
Oct 12, 2019
|
|
||
| `events_statements_summary_by_digest` 现在还存在一些限制： | ||
|
|
||
| - 查询 `events_statements_summary_by_digest` 时，只会显示当前 TiDB-Server 的 statement summary，而不是整个群集的 statement summary。 |
There was a problem hiding this comment.
Suggested change
| - 查询 `events_statements_summary_by_digest` 时，只会显示当前 TiDB-Server 的 statement summary，而不是整个群集的 statement summary。 | |
| - 查询 `events_statements_summary_by_digest` 时，只会显示当前 TiDB-Server 的 statement summary，而不是整个集群的 statement summary。 |
dcalvin
added
translation/done
|
@djshow832 Please add a reason why you closed this PR and add the related PR if possible. @dcalvin FYI. |
|
This PR is closed. Updates are made in a new PR #1939. |
lilin90
removed
the
translation/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
Add documentation for statement summary.
Statement summary is recently released, and a documentation is needed to guide users.
What is the related PR or file link(s)?
master: pingcap/tidb#12017, pingcap/tidb#12217
release 3.0: pingcap/tidb#12306, pingcap/tidb#12308
release 3.1: pingcap/tidb#12328, pingcap/tidb#12499
Which version does your change affect?
dev, v3.0