Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev, v3.0/tidb-in-kubernetes: tidb keep alive troubleshooting #1864

Merged
merged 6 commits into from
Sep 18, 2019

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Sep 16, 2019

What is changed, added or deleted?

Add troubleshooting notes about TCP keep alive.

What is the related PR or file link(s)?

pingcap/tidb-operator#880
pingcap/tidb-operator#915

Which version does your change affect?

dev
v3.0

@cofyc cofyc requested a review from aylei September 16, 2019 03:42
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以先确认 dev 里的 comments 都解决好后,最后再粘贴至 v3.0 的相应文件内。

dev/tidb-in-kubernetes/troubleshoot.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/troubleshoot.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/troubleshoot.md Outdated Show resolved Hide resolved
@yikeke yikeke added translation/doing This PR’s assignee is translating this PR. dev labels Sep 16, 2019
cofyc and others added 4 commits September 16, 2019 13:23
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor Author

cofyc commented Sep 16, 2019

hold this until pingcap/tidb-operator#915 is merged.

@cofyc cofyc merged commit b75904d into pingcap:master Sep 18, 2019
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants