Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: fix format issue in show table regions #17385

Merged
merged 2 commits into from
May 20, 2024
Merged

sql: fix format issue in show table regions #17385

merged 2 commits into from
May 20, 2024

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented May 20, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

Fix format display error in SHOW TABLE REGIONS and add inline code format for some descriptions
image

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug. labels May 20, 2024
@lilin90 lilin90 self-assigned this May 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2024
@lilin90 lilin90 marked this pull request as ready for review May 20, 2024 06:59
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 20, 2024
@lilin90 lilin90 requested a review from Oreoxmt May 20, 2024 06:59
@lilin90 lilin90 added needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels May 20, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-20 08:35:06.937727755 +0000 UTC m=+2074260.694863321: ☑️ agreed by Oreoxmt.

@lilin90 lilin90 added the lgtm label May 20, 2024
lilin90
lilin90 commented May 20, 2024
View reviewed changes
Copy link
Member Author

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1448a09 into pingcap:master May 20, 2024
7 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #17408.

@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #17409.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17410.

@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #17411.

This was referenced May 20, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #17412.

@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #17413.

@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #17414.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17415.

@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17416.

@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2024
Merged
16 tasks
@lilin90 lilin90 deleted the fix-format-show-table-region branch May 21, 2024 03:29
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17407)
653c9aa
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17406)
c50d679
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17411)
8af598f
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17412)
3fb7342
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17414)
7ef6646
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17408)
d39e7be
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17409)
f9af76b
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17413)
2c4de64
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17416)
5545915
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17415)
029b510
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
sql: fix format issue in show table regions (#17385) (#17410)
b399ef0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@lilin90 lilin90

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilin90 @ti-chi-bot @Oreoxmt