-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/reference, v3.0/reference, v2.1/reference: add safe-mode config in binlog reparo doc #1558
Conversation
Important Update: We have added a markdownlint static check in the CI check to improve the quality of our documentation, so your unclosed PR might fail the CI check now. First, you should merge upstream master to your branch, so the upstream changes might resolve the issues found by the CI check. Then, click @ericsyh If you have any problem with troubleshooting, please consult @yikeke for help. Thanks for your cooperation~ Ref: #1494 |
LGTM |
Please remove the hard tab in the Line 36 of the changed |
Okay, i will fix it. |
apply Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
apply Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is changed, added or deleted?
In pingcap/tidb-binlog#652 we add a new config
safe-mode
in reparo, this PR this to update the reparo documents about the new config.What is the related PR or file link(s)?
In pingcap/tidb-binlog#652.
Which version does your change affect?
Apply in dev/v3.0/v2.1