Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysvar: add 12 sysvars to docs-cn #11495

Merged
merged 4 commits into from
Oct 13, 2022
Merged

sysvar: add 12 sysvars to docs-cn #11495

merged 4 commits into from
Oct 13, 2022

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Oct 8, 2022 •
edited
Loading

What is changed, added or deleted? (Required)

sysvar: add 13 sysvars to docs-cn

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2022
@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. add-missing-docs Add missing system variables, configuration items, and experimental features to documentation needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 and removed missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 8, 2022
@TomShawn TomShawn added needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Oct 8, 2022
@TomShawn TomShawn changed the title sysvar: add 13 sysvars to docs-cn sysvar: add 12 sysvars to docs-cn Oct 8, 2022
@ran-huang ran-huang self-requested a review October 8, 2022 08:45
@ran-huang ran-huang mentioned this pull request Oct 11, 2022
Merged
8 tasks
ran-huang
ran-huang reviewed Oct 11, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
ran-huang
ran-huang approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2022
@TomShawn @ran-huang
Apply suggestions from code review
9507097 
Co-authored-by: Ran <huangran.alex@gmail.com>
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Oct 13, 2022
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9507097

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2022
@ti-chi-bot ti-chi-bot merged commit 0c875e6 into pingcap:master Oct 13, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11602.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 13, 2022
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#11495
4e788ed 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11603.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11604.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 13, 2022
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#11495
7b4df67 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11605.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2022
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 13, 2022
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#11495
03c87a8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11606.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 13, 2022
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#11495
a4b2dbf 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 13, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11607.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Oct 13, 2022
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#11495
d391033 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@TomShawn TomShawn deleted the btacg-sysvar branch October 13, 2022 03:55
ti-chi-bot added a commit that referenced this pull request Oct 13, 2022
@ti-chi-bot
sysvar: add 12 sysvars to docs-cn (#11495) (#11603)
c779143
ti-chi-bot added a commit that referenced this pull request Oct 13, 2022
@ti-chi-bot
sysvar: add 12 sysvars to docs-cn (#11495) (#11602)
45d14df
ti-chi-bot added a commit that referenced this pull request Oct 13, 2022
@ti-chi-bot
sysvar: add 12 sysvars to docs-cn (#11495) (#11604)
7797a95
TomShawn added a commit that referenced this pull request Oct 13, 2022
@ti-chi-bot @TomShawn
sysvar: add 12 sysvars to docs-cn (#11495) (#11605)
ba7cc4d 
* This is an automated cherry-pick of #11495

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Update aggregate-group-by-functions.md

* Apply suggestions from code review

* Update aggregate-group-by-functions.md

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
ti-chi-bot added a commit that referenced this pull request Oct 13, 2022
@ti-chi-bot
sysvar: add 12 sysvars to docs-cn (#11495) (#11606)
e8351cd
ti-chi-bot added a commit that referenced this pull request Oct 13, 2022
@ti-chi-bot
sysvar: add 12 sysvars to docs-cn (#11495) (#11607)
ef59888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

Assignees
No one assigned
Labels
add-missing-docs Add missing system variables, configuration items, and experimental features to documentation needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-chi-bot @ran-huang