Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

update tools dependency #663

Merged
merged 4 commits into from
May 15, 2020
Merged

update tools dependency #663

merged 4 commits into from
May 15, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

update tidb-tools to solve table name changing after applyOn black-white-list, details at pingcap/tidb-tools#342

What is changed and how it works?

change tidb-tools to latest version

Check List

Tests

  • Unit test
  • Integration test

@lichunzhu lichunzhu added status/PTAL This PR is ready for review. Add this label back after committing new changes dependencies Pull requests that update a dependency file labels May 14, 2020
csuzhangxc
csuzhangxc reviewed May 14, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels May 14, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 beta.2 milestone May 14, 2020
@lichunzhu
Copy link
Contributor Author

/run-all-tests

2 similar comments
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@csuzhangxc
Copy link
Member

@GMHDBJD PTAL

@csuzhangxc csuzhangxc requested a review from GMHDBJD May 15, 2020 02:02
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #663 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #663   +/-   ##
===========================================
  Coverage   57.6988%   57.6988%           
===========================================
  Files           203        203           
  Lines         20581      20581           
===========================================
  Hits          11875      11875           
  Misses         7563       7563           
  Partials       1143       1143

GMHDBJD
GMHDBJD approved these changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu merged commit 102876c into pingcap:master May 15, 2020
@lichunzhu lichunzhu deleted the updateToolDepend branch May 15, 2020 03:15
@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.0.0 beta.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lichunzhu @csuzhangxc @GMHDBJD