Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

conn: refine TLS configuration (#1575) #1578

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Apr 9, 2021

cherry-pick #1575 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1578

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1578:release-2.0-5ebe8d9e5b7d

What problem does this PR solve?

Fix CI for #1560. close #1560

What is changed and how it works?

Set TLS too even if we only have ssl-ca.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot ti-srebot added size/L type/cherry-pick This PR is just a cherry-pick (backport) labels Apr 9, 2021
@lance6716 lance6716 merged commit 3b4d726 into pingcap:release-2.0 Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor size/L type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants