Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support django 5.0 #61

Merged
merged 5 commits into from
Apr 8, 2024
Merged

support django 5.0 #61

merged 5 commits into from
Apr 8, 2024

Conversation

wd0517
Copy link
Collaborator

@wd0517 wd0517 commented Apr 6, 2024

Django 5.0 New Feature (db related):

  1. Database-computed default values, TiDB has limited support for default value expressions, see docs.
  2. Database generated model field, TiDB also has some limitations.

This PR also dropped support for TiDB 4.x as it has already reached its EOL.

There are two TiDB bugs discovered by the Django test suite that need to be tracked:

@wd0517 wd0517 marked this pull request as draft April 6, 2024 07:57
@wd0517 wd0517 marked this pull request as ready for review April 7, 2024 03:14
@dveeden
Copy link
Contributor

dveeden commented Apr 8, 2024

@wd0517 the description says "This PR also dropped support for TiDB 5.x as it has already reached its EOL." But this doesn't look to match with the changes. Isn't this dropping support for TiDB 4.x instead?

@wd0517
Copy link
Collaborator Author

wd0517 commented Apr 8, 2024

@wd0517 the description says "This PR also dropped support for TiDB 5.x as it has already reached its EOL." But this doesn't look to match with the changes. Isn't this dropping support for TiDB 4.x instead?

Sorry, it was a typo, drop support for TiDB 4.x

@wd0517 wd0517 merged commit 113d1e9 into main Apr 8, 2024
10 checks passed
@wd0517 wd0517 deleted the wd/support-django-5.0 branch April 8, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants