Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support vector field #60

Merged
merged 9 commits into from
Mar 18, 2024
Merged

support vector field #60

merged 9 commits into from
Mar 18, 2024

Conversation

wd0517
Copy link
Collaborator

@wd0517 wd0517 commented Mar 13, 2024

Now TiDB serverless support vector data type, this pr let django-tidb support VectorField to communite with it.

Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for this to be in public beta and/or pingcap/tidb master?

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any testing/CI for this?

django_tidb/fields/vector.py Show resolved Hide resolved
@wd0517
Copy link
Collaborator Author

wd0517 commented Mar 13, 2024

Should we wait for this to be in public beta and/or pingcap/tidb master?

As far as I know, PingCAP will soon (private preview may be April?) release the vector data type in TiDB Serverless. We should prepare the SDK beforehand and do not need to wait for public beta. Additionally, we have already marked VectorField as beta in the document.

Co-authored-by: Daniël van Eeden <git@myname.nl>
@wd0517
Copy link
Collaborator Author

wd0517 commented Mar 13, 2024

Is there any testing/CI for this?

There are only manual test for now, since it can only test in TiDB Serverless, its not suitable for current test script.

wd0517 and others added 2 commits March 13, 2024 17:29
Co-authored-by: Daniël van Eeden <git@myname.nl>
@zhangyangyu
Copy link
Member

zhangyangyu commented Mar 16, 2024

Treat it as a variant or default? Maybe just like some features are only available on some specific versions? Sooner or later I think the vector feature should be available in all TiDB deployments.

@wd0517
Copy link
Collaborator Author

wd0517 commented Mar 17, 2024

Treat it as a variant or default? Maybe just like some features are only available on some specific versions? Sooner or later I think the vector feature should be available in all TiDB deployments.

It will only works in TiDB Cloud Serverless Cluster as far as I know, I haven't received a clear plan regarding when it will be available in pingcap/tidb master.

The VectorField is defined and enabled by the user, not as a built-in feature. Therefore, there is no need to check the TiDB version in django-tidb.

@wd0517
Copy link
Collaborator Author

wd0517 commented Mar 17, 2024

Add tests: 46f73a0

There is currently only one test cluster available, so it does not support running tests in parallel. I will utilize the TiDB Serverless branch feature once vector is released to TiDB Cloud Production.

@wd0517 wd0517 merged commit 137c475 into main Mar 18, 2024
10 checks passed
@wd0517 wd0517 deleted the wd/vector branch March 18, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants