-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add TiDB v7.1 & Django v4.2 #42
Conversation
Nice job! But I think we should add Python 3.11, it's the current bugfix Python version. |
there is a bug or a improvement in python 3.11.4, not releated to django-tidb, I will switch to using python 3.11.3 for running the tests
python 3.9
|
It's an security improvement: https://docs.python.org/release/3.11.4/whatsnew/changelog.html#python-3-11-4 Django has already fixed this issue in versions 4.2.x and 4.1.x, but not in version 3.2.x, even though 3.2 is a TLS version and support ends in April 2024. Django Supported Versions, I will report this problem to Django. |
@wd0517 I don't look into the Django test, but for the code snippet failed: >>> from urllib.parse import urlsplit
>>> urlsplit('http://[::1:2::3]/') I think it's not due to the security fix in 3.11.4, but this fix python/cpython@b2171a2. |
JSON
related tests are expected to fail because of Does not fully supportJSON
because Django has some hard code formysql
inJSONField
#38, I will fix it in next prdebug_transaction
feature in version 4.2.x, but it does not consider databases that do not support savepoints(TiDB < 6.2.0), this results in allassertNumQueries
test cases failing, for example: