Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

restore: don't restore auto id if the table doesn't has it. (#420) #720

Merged
merged 3 commits into from
Jan 27, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 26, 2021

cherry-pick #420 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/720

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/br.git pr/720:release-4.0-63904530ee77

What problem does this PR solve?

Fix CI failure after tidb#18326

What is changed and how it works?

We don't try to restore auto ID for tables that don't need it.

Check List

Tests

  • Integration test

Release Note

  • fix a bug that causes, we will restore auto id even the table doesn't has it.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@glorv
Copy link
Collaborator

glorv commented Jan 27, 2021

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Jan 27, 2021
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jan 27, 2021
@3pointer 3pointer merged commit 022d477 into pingcap:release-4.0 Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants